🌱 Explicitly set NODE_ENV for npm scripts #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Being explicit about what the `NODE_ENV` value should be for each npm script where the value could impact the results can help remove any errors in future. Motivated by working on konveyor#1502. Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1504 +/- ##
=======================================
Coverage 40.60% 40.60%
=======================================
Files 145 145
Lines 4586 4586
Branches 1074 1106 +32
=======================================
Hits 1862 1862
+ Misses 2712 2627 -85
- Partials 12 97 +85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ibolton336
approved these changes
Nov 1, 2023
gitdallas
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being explicit about what the
NODE_ENVvalue should be for each npm script where the value could impact the results can help remove any errors in future. Motivated by working on #1502.