👻 Default to production for NODE_ENV

[ibolton336]

Fixes https://issues.redhat.com/browse/MTA-1599

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d3eb379) 40.16% compared to head (2ce4d7d) 40.60%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1502      +/-   ##
==========================================
+ Coverage   40.16%   40.60%   +0.43%     
==========================================
  Files         144      145       +1     
  Lines        4551     4586      +35     
  Branches     1096     1106      +10     
==========================================
+ Hits         1828     1862      +34     
- Misses       2626     2627       +1     
  Partials       97       97              

Flag	Coverage Δ
client	40.60% <97.14%> (+0.43%)	⬆️
server	∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
client/src/app/env.ts	100.00% <100.00%> (ø)
client/src/mocks/config.ts	97.05% <97.05%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sjd78]

Yeah, the destructuring in buildKonveyorEnv to convert process.env to the internal ENV was filtering out optional values that I hadn't included.

[ibolton336]

Yeah, the destructuring in buildKonveyorEnv to convert process.env to the internal ENV was filtering out optional values that I hadn't included.

Didn't appear to impact the issue at hand, but is nice to have the defaults explicitly included to enhance the dev experience. Seems that the result of buildKonveyorEnv includes all of the env vars available from process.env at runtime even if the type definition constrains the expected properties. TypeScript type checking occurs at compile-time, and it doesn't prevent you from accessing properties not explicitly defined in the type.

If we wanted to ensure that only the expected properties are included and to have stricter type checking, we could explicitly specify the properties we want from process.env

const konveyorEnv = buildKonveyorEnv({
  NODE_ENV: process.env.NODE_ENV,
  VERSION: process.env.VERSION,
  MOCK: process.env.MOCK,
  AUTH_REQUIRED: process.env.AUTH_REQUIRED,
  KEYCLOAK_REALM: process.env.KEYCLOAK_REALM,
  KEYCLOAK_CLIENT_ID: process.env.KEYCLOAK_CLIENT_ID,
  PROFILE: process.env.PROFILE,
  UI_INGRESS_PROXY_BODY_SIZE: process.env.UI_INGRESS_PROXY_BODY_SIZE,
  RWX_SUPPORTED: process.env.RWX_SUPPORTED,
});