Moved binary analysis to TIER0 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mguetta1
force-pushed
the
binary-analysis
branch
from
43bcaf7
to
cd5cfff
Compare
|
The PR looks good 👍 , but we might wait with merging to confirm current tier0 analysis output is correct. |
aufi
previously approved these changes
Aug 5, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
mguetta1
force-pushed
the
binary-analysis
branch
from
cd5cfff
to
70d2f27
Compare
mguetta1
added
the
cherry-pick/release-0.5
aufi
dismissed
their stale review
Need to look deeper and debug on this change
sshveta
approved these changes
Aug 28, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
mguetta1
added
the
cherry-pick/release-0.3
mguetta1
removed
the
cherry-pick/release-0.3
aufi
added a commit
to aufi/go-konveyor-tests
that referenced
this pull request
Sep 4, 2024
Updating test for Tackle Testapp Public Binary analysis and related test data. Related to konveyor#161, konveyor#169, replaces konveyor#168 Signed-off-by: Marek Aufart <maufart@redhat.com>
This was referenced Sep 4, 2024
aufi
added a commit
that referenced
this pull request
Sep 13, 2024
* Move TackletestApp binary fomr TIER0 Proposing partially revert PR#161 Testapp Binary test assignment to TIER0 to unblock CI on-PR checks that are holding our colleagues work in Konveyor repos from being merged. The original PR#161 moved TackleTestapp Public "binary" test into TIER0 however it was _still failing_. The issue is already reported as https://issues.redhat.com/browse/MTA-3654, so I'd strongly prefer escalate the Jira issue to merging failing test. Signed-off-by: Marek Aufart <maufart@redhat.com> * Update TackleTestapp binary tests Updating test for Tackle Testapp Public Binary analysis and related test data. Related to #161, #169, replaces #168 Signed-off-by: Marek Aufart <maufart@redhat.com> * Update test_cases names Signed-off-by: Marek Aufart <maufart@redhat.com> --------- Signed-off-by: Marek Aufart <maufart@redhat.com>
mguetta1
added a commit
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
mguetta1
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Move TackletestApp binary fomr TIER0 Proposing partially revert PR#161 Testapp Binary test assignment to TIER0 to unblock CI on-PR checks that are holding our colleagues work in Konveyor repos from being merged. The original PR#161 moved TackleTestapp Public "binary" test into TIER0 however it was _still failing_. The issue is already reported as https://issues.redhat.com/browse/MTA-3654, so I'd strongly prefer escalate the Jira issue to merging failing test. Signed-off-by: Marek Aufart <maufart@redhat.com> * Update TackleTestapp binary tests Updating test for Tackle Testapp Public Binary analysis and related test data. Related to #161, #169, replaces #168 Signed-off-by: Marek Aufart <maufart@redhat.com> * Update test_cases names Signed-off-by: Marek Aufart <maufart@redhat.com> --------- Signed-off-by: Marek Aufart <maufart@redhat.com>
mguetta1
added a commit
to mguetta1/go-konveyor-tests
that referenced
this pull request
Sep 25, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
mguetta1
pushed a commit
to mguetta1/go-konveyor-tests
that referenced
this pull request
Sep 25, 2024
* Move TackletestApp binary fomr TIER0 Proposing partially revert PR#161 Testapp Binary test assignment to TIER0 to unblock CI on-PR checks that are holding our colleagues work in Konveyor repos from being merged. The original PR#161 moved TackleTestapp Public "binary" test into TIER0 however it was _still failing_. The issue is already reported as https://issues.redhat.com/browse/MTA-3654, so I'd strongly prefer escalate the Jira issue to merging failing test. Signed-off-by: Marek Aufart <maufart@redhat.com> * Update TackleTestapp binary tests Updating test for Tackle Testapp Public Binary analysis and related test data. Related to konveyor#161, konveyor#169, replaces konveyor#168 Signed-off-by: Marek Aufart <maufart@redhat.com> * Update test_cases names Signed-off-by: Marek Aufart <maufart@redhat.com> --------- Signed-off-by: Marek Aufart <maufart@redhat.com>
mguetta1
pushed a commit
to mguetta1/go-konveyor-tests
that referenced
this pull request
Sep 25, 2024
* Move TackletestApp binary fomr TIER0 Proposing partially revert PR#161 Testapp Binary test assignment to TIER0 to unblock CI on-PR checks that are holding our colleagues work in Konveyor repos from being merged. The original PR#161 moved TackleTestapp Public "binary" test into TIER0 however it was _still failing_. The issue is already reported as https://issues.redhat.com/browse/MTA-3654, so I'd strongly prefer escalate the Jira issue to merging failing test. Signed-off-by: Marek Aufart <maufart@redhat.com> * Update TackleTestapp binary tests Updating test for Tackle Testapp Public Binary analysis and related test data. Related to konveyor#161, konveyor#169, replaces konveyor#168 Signed-off-by: Marek Aufart <maufart@redhat.com> * Update test_cases names Signed-off-by: Marek Aufart <maufart@redhat.com> --------- Signed-off-by: Marek Aufart <maufart@redhat.com>
mguetta1
pushed a commit
to mguetta1/go-konveyor-tests
that referenced
this pull request
Sep 25, 2024
* Move TackletestApp binary fomr TIER0 Proposing partially revert PR#161 Testapp Binary test assignment to TIER0 to unblock CI on-PR checks that are holding our colleagues work in Konveyor repos from being merged. The original PR#161 moved TackleTestapp Public "binary" test into TIER0 however it was _still failing_. The issue is already reported as https://issues.redhat.com/browse/MTA-3654, so I'd strongly prefer escalate the Jira issue to merging failing test. Signed-off-by: Marek Aufart <maufart@redhat.com> * Update TackleTestapp binary tests Updating test for Tackle Testapp Public Binary analysis and related test data. Related to konveyor#161, konveyor#169, replaces konveyor#168 Signed-off-by: Marek Aufart <maufart@redhat.com> * Update test_cases names Signed-off-by: Marek Aufart <maufart@redhat.com> --------- Signed-off-by: Marek Aufart <maufart@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also taking care of #127