Update test applications #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidating samples Applications used for analysis tests to data pks started by Maayan. Most used `TackleTestApp` now explicitly uses main git branch, there is also `gradle` branch expected for TackleTestAppGradle. Signed-off-by: Marek Aufart <maufart@redhat.com>
aufi
commented
Jun 7, 2024
| Repository: &api.Repository{ | ||
| Kind: "git", | ||
| URL: "https://github.com/konveyor/tackle-testapp-public", | ||
| Branch: "gradle", |
There was a problem hiding this comment.
I'm not sure if the is right to have gradle branch or some other solution, feedback is welcome.
I was just thinking that having different test applications for different releases is not very handy for tests debugging and stability. Feeling as better to be able say that TestAppXY analysis works on release-0.2 and 0.3, but is broken on 0.4, than having the "same" application that behaves differently across releases.
mguetta1
requested changes
Jun 9, 2024
| @@ -26,7 +26,7 @@ var ( | |||
| URL: "https://github.com/ibraginsky/book-server", | |||
| }, | |||
| } | |||
| TackleTestapp = api.Application{ | |||
| TackleTestappBin = api.Application{ | |||
There was a problem hiding this comment.
The application can be used not only for binary analysis.
I suggest usingTackleTestappPrivate/TackleTestappPublic
|
Closing in favor of #161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidating samples Applications used for analysis tests to data pks started by Maayan.
Most used
TackleTestAppnow explicitly uses main git branch, there is alsogradlebranch expected for TackleTestAppGradle.