chore(linting): migration tslint to eslint #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like this will be adjust, looks good to me! |
vikiival
requested changes
Sep 29, 2021
.editorconfig
Outdated
| @@ -13,18 +13,18 @@ charset = utf-8 | |||
|
|
|||
| # Indentation override for all JS | |||
| [**.js] | |||
| indent_style = space | |||
| indent_style = tab | |||
There was a problem hiding this comment.
is this evergreen bikeshed discussion on every project 😅
let's go with tabs :D
There was a problem hiding this comment.
Because she told you that she needs some space
I would not mind to use tabs but the code is not properly formatted
There was a problem hiding this comment.
Let's agree to use "space: 2", I'm currently fighting to fix "Mixed spaces and tabs" on .vue files.
There was a problem hiding this comment.
well, tabs could be space 2 tho :)
then there is another discussion about indentation... 2 or 4 😄
.eslintrc.js
Outdated
| 'plugin:vue/recommended', | ||
| // 'prettier', | ||
| ], | ||
| 'env': { |
|
For me is good to go! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big changes over here.
Usage:
To show problems on all files (.js, .ts, .vue):
To only show errors:
Automatic fix:
Right now we've got 1236 problems (0 errors, 1236 warnings)
Next step would be to add this command on our Github Workflow.
Indentation:
To easily convert tab to space or space to tab you will need to edit .eslintrc.js file & .editorconfig
then you can use
yarn lint --fixPR type
What's new? (may be part of changelog)