Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As Dev I would like to have a standardised code formatting. #641

Closed
vikiival opened this issue Aug 25, 2021 · 2 comments · Fixed by #822
Closed

As Dev I would like to have a standardised code formatting. #641

vikiival opened this issue Aug 25, 2021 · 2 comments · Fixed by #822
Labels
enhancement New feature or request p4 affecting less than 10% of app

Comments

@vikiival
Copy link
Member

Is your feature request related to a problem? Please describe.
"I think we should standardized code quality i've seen some files with different style (some with spaces without semicolon others with tabs)"

Describe the solution you'd like
Some sort of standardised prettier would be enough for now

Describe alternatives you've considered
Have a pre-push hook which lints the code 👁️

@vikiival vikiival added enhancement New feature or request A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama labels Aug 25, 2021
@roiLeo
Copy link
Contributor

roiLeo commented Aug 26, 2021

Command to fix errors:
yarn tslint --fix -c tslint.json 'src/**/*{.ts,.tsx}'

EDIT: command not safe 😕

EDIT2: Looks like tslint has been deprecated since 2019. It should be replaced with typescript-eslint.

@vikiival
Copy link
Member Author

Unless we do not have normal code formatting, I disabled the semi (it's super annoying)
b957cab

@vikiival vikiival added p4 affecting less than 10% of app and removed A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama labels Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p4 affecting less than 10% of app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants