Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: bug fixes for 0.21 #793

Merged
merged 5 commits into from
Jan 27, 2022

Conversation

lance
Copy link
Member

@lance lance commented Jan 27, 2022

Changes

matejvasek and others added 5 commits January 27, 2022 11:27
* fix: auth check

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix: auth check

Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
The builder image name should include the registry name. Also it seems
that the tiny builder doesn't actually work. We need base.

Fixes: knative#775

Signed-off-by: Lance Ball <lball@redhat.com>
The build actually seems to require `base` vs `tiny.

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance requested a review from matejvasek January 27, 2022 18:19
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 27, 2022
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #793 (eead4c1) into release-0.21 (a579391) will increase coverage by 3.38%.
The diff coverage is 25.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-0.21     #793      +/-   ##
================================================
+ Coverage         41.52%   44.91%   +3.38%     
================================================
  Files                42       42              
  Lines              4101     3747     -354     
================================================
- Hits               1703     1683      -20     
+ Misses             2145     1812     -333     
+ Partials            253      252       -1     
Impacted Files Coverage Δ
docker/creds/credentials.go 67.82% <25.00%> (-0.02%) ⬇️
knative/deployer.go 1.85% <0.00%> (-3.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a579391...eead4c1. Read the comment docs.

@matejvasek
Copy link
Contributor

/lgtm
/hold until test pass

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2022
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
@lance
Copy link
Member Author

lance commented Jan 27, 2022

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2022
@knative-prow-robot knative-prow-robot merged commit 947f982 into knative:release-0.21 Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants