-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport: bug fixes for 0.21 #793
Conversation
* fix: auth check Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: auth check Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
The builder image name should include the registry name. Also it seems that the tiny builder doesn't actually work. We need base. Fixes: knative#775 Signed-off-by: Lance Ball <lball@redhat.com>
The build actually seems to require `base` vs `tiny. Signed-off-by: Lance Ball <lball@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## release-0.21 #793 +/- ##
================================================
+ Coverage 41.52% 44.91% +3.38%
================================================
Files 42 42
Lines 4101 3747 -354
================================================
- Hits 1703 1683 -20
+ Misses 2145 1812 -333
+ Partials 253 252 -1
Continue to review full report at Codecov.
|
/lgtm |
/unhold |
Changes