-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use paketo base image for springboot #792
Conversation
The build actually seems to require `base` vs `tiny. Signed-off-by: Lance Ball <lball@redhat.com>
@lance: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #792 +/- ##
=======================================
Coverage 44.41% 44.41%
=======================================
Files 47 47
Lines 4296 4296
=======================================
Hits 1908 1908
Misses 2108 2108
Partials 280 280 Continue to review full report at Codecov.
|
/tgtm |
Yea |
/lgtm |
The build actually seems to require `base` vs `tiny. Signed-off-by: Lance Ball <lball@redhat.com>
* fix: auth check (#773) * fix: auth check Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: auth check Signed-off-by: Matej Vasek <mvasek@redhat.com> * chore: skip integration tests for now (#780) Signed-off-by: Lance Ball <lball@redhat.com> * fix: error type-check condition (#786) Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: use domain qualified registry for springboot (#789) The builder image name should include the registry name. Also it seems that the tiny builder doesn't actually work. We need base. Fixes: #775 Signed-off-by: Lance Ball <lball@redhat.com> * fix: use paketo base image for springboot (#792) The build actually seems to require `base` vs `tiny. Signed-off-by: Lance Ball <lball@redhat.com> Co-authored-by: Matej Vasek <mvasek@redhat.com>
🐛 The build actually seems to require
base
vstiny
./kind fix
Signed-off-by: Lance Ball lball@redhat.com