Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use paketo base image for springboot #792

Merged
merged 1 commit into from
Jan 27, 2022
Merged

fix: use paketo base image for springboot #792

merged 1 commit into from
Jan 27, 2022

Conversation

lance
Copy link
Member

@lance lance commented Jan 27, 2022 •
edited

🐛 The build actually seems to require base vs tiny.

/kind fix

Signed-off-by: Lance Ball lball@redhat.com

Changes the springboot function templates to use the base builder instead of the tiny builder.

@lance
fix: use paketo base image for springboot
a7367ca 
The build actually seems to require `base` vs `tiny.

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance requested a review from matejvasek January 27, 2022 15:50
@knative-prow-robot
Copy link

@lance: The label(s) kind/fix cannot be applied, because the repository doesn't have them.

In response to this:

🐛 The build actually seems to require base vs `tiny.

/kind fix

Signed-off-by: Lance Ball lball@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 27, 2022
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #792 (a7367ca) into main (6097b8d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #792   +/-   ##
=======================================
  Coverage   44.41%   44.41%           
=======================================
  Files          47       47           
  Lines        4296     4296           
=======================================
  Hits         1908     1908           
  Misses       2108     2108           
  Partials      280      280

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6097b8d...a7367ca. Read the comment docs.

@jrangelramos
Copy link
Contributor

/tgtm

@jrangelramos
Copy link
Contributor

Yea base builds fine!!!

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
@knative-prow-robot knative-prow-robot merged commit ece9ac3 into knative:main Jan 27, 2022
lance added a commit to lance/func that referenced this pull request Jan 27, 2022
@lance
fix: use paketo base image for springboot (knative#792)
eead4c1 
The build actually seems to require `base` vs `tiny.

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance mentioned this pull request Jan 27, 2022
Merged
knative-prow-robot pushed a commit that referenced this pull request Jan 27, 2022
@lance @matejvasek
backport: bug fixes for 0.21 (#793)
947f982 
* fix: auth check (#773)

* fix: auth check

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix: auth check

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* chore: skip integration tests for now (#780)

Signed-off-by: Lance Ball <lball@redhat.com>

* fix: error type-check condition (#786)

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix: use domain qualified registry for springboot (#789)

The builder image name should include the registry name. Also it seems
that the tiny builder doesn't actually work. We need base.

Fixes: #775

Signed-off-by: Lance Ball <lball@redhat.com>

* fix: use paketo base image for springboot (#792)

The build actually seems to require `base` vs `tiny.

Signed-off-by: Lance Ball <lball@redhat.com>

Co-authored-by: Matej Vasek <mvasek@redhat.com>
@lance lance added the kind/bug Categorizes issue or PR as related to a bug. label Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejvasek matejvasek Awaiting requested review from matejvasek

Assignees

@matejvasek matejvasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lance @knative-prow-robot @jrangelramos @matejvasek