Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pack to v0.33.0 #2148

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

matejvasek
Copy link
Contributor

Changes

Updated pack to v0.33.0.

Fixes: #2097

fix: "no main packages to build" on darwin/aarch64

Copy link

knative-prow bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 7, 2024
@matejvasek matejvasek requested review from gauron99 and lkingland and removed request for navidshaikh February 7, 2024 13:12
@matejvasek
Copy link
Contributor Author

/cc muhsin09

Copy link

knative-prow bot commented Feb 7, 2024

@matejvasek: GitHub didn't allow me to request PR reviews from the following users: muhsin09.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc muhsin09

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matejvasek
Copy link
Contributor Author

/cc @muhsin09

Copy link

knative-prow bot commented Feb 7, 2024

@matejvasek: GitHub didn't allow me to request PR reviews from the following users: muhsin09.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @muhsin09

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matejvasek
Copy link
Contributor Author

@muhsin09 please check if this works.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69aaed9) 59.02% compared to head (6af10b1) 65.14%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2148      +/-   ##
==========================================
+ Coverage   59.02%   65.14%   +6.12%     
==========================================
  Files         102      108       +6     
  Lines       13705    13918     +213     
==========================================
+ Hits         8089     9067     +978     
+ Misses       4810     3952     -858     
- Partials      806      899      +93     
Flag Coverage Δ
e2e-test 37.32% <0.00%> (?)
e2e-test-oncluster 30.50% <0.00%> (?)
e2e-test-oncluster-runtime 26.83% <0.00%> (?)
e2e-test-runtime-go 25.53% <0.00%> (?)
e2e-test-runtime-node 26.57% <0.00%> (?)
e2e-test-runtime-python 26.57% <0.00%> (?)
e2e-test-runtime-quarkus 26.68% <0.00%> (?)
e2e-test-runtime-rust 25.58% <0.00%> (?)
e2e-test-runtime-springboot 25.71% <0.00%> (?)
e2e-test-runtime-typescript 26.68% <0.00%> (?)
integration-tests 51.87% <100.00%> (+2.03%) ⬆️
unit-tests-macos-latest 48.84% <100.00%> (-0.01%) ⬇️
unit-tests-ubuntu-latest 49.57% <100.00%> (-0.01%) ⬇️
unit-tests-windows-latest 48.87% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek
Copy link
Contributor Author

@jrangelramos
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2024
@jrangelramos
Copy link
Contributor

/hold for others

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2024
@matejvasek
Copy link
Contributor Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2024
@knative-prow knative-prow bot merged commit 37285a0 into knative:main Feb 9, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no main packages to build
2 participants