Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildpack updated to v0.32.1 #2102

Closed
wants to merge 5 commits into from
Closed

buildpack updated to v0.32.1 #2102

wants to merge 5 commits into from

Conversation

muhsin09
Copy link

@muhsin09 muhsin09 commented Dec 6, 2023

Changes

  • 🐛 Fix bug
  • old version of buildpack not working on Apple Silicon chips(m2)
  • buildpack upgraded to newer version(v0.32.1)

/kind bug

Fixes #2097

Release Note

'kn func build' command on golang tamplate now works on Apple Silicon chips
Buildpack version updated to v0.32.1

Docs


Copy link

knative-prow bot commented Dec 6, 2023

@muhsin09: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

linux-foundation-easycla bot commented Dec 6, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 6, 2023
Copy link

knative-prow bot commented Dec 6, 2023

Welcome @muhsin09! It looks like this is your first PR to knative/func 🎉

Copy link

knative-prow bot commented Dec 6, 2023

Hi @muhsin09. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 6, 2023
Copy link

knative-prow bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: muhsin09
Once this PR has been reviewed and has the lgtm label, please assign retocode for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muhsin09 muhsin09 changed the title golang no main package error buildpack updated to v0.32.1 Dec 6, 2023
@aliok
Copy link
Member

aliok commented Dec 6, 2023

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f1568c) 63.90% compared to head (6df00c8) 64.85%.
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2102      +/-   ##
==========================================
+ Coverage   63.90%   64.85%   +0.95%     
==========================================
  Files         108      108              
  Lines       13868    13868              
==========================================
+ Hits         8862     8994     +132     
+ Misses       4138     3981     -157     
- Partials      868      893      +25     
Flag Coverage Δ
e2e-test 36.66% <ø> (ø)
e2e-test-oncluster 30.54% <ø> (-0.03%) ⬇️
e2e-test-oncluster-runtime 26.82% <ø> (?)
e2e-test-runtime-go 25.57% <ø> (?)
e2e-test-runtime-node 26.56% <ø> (?)
e2e-test-runtime-python 26.56% <ø> (?)
e2e-test-runtime-quarkus 26.68% <ø> (?)
e2e-test-runtime-rust 25.57% <ø> (?)
e2e-test-runtime-springboot 25.70% <ø> (?)
e2e-test-runtime-typescript 26.68% <ø> (?)
integration-tests 51.76% <ø> (+1.97%) ⬆️
unit-tests-macos-latest 48.74% <ø> (-0.03%) ⬇️
unit-tests-ubuntu-latest 49.51% <ø> (ø)
unit-tests-windows-latest 48.79% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aliok
Copy link
Member

aliok commented Dec 6, 2023

/retest

Signed-off-by: muhsin.ozbek <muhsin.ozbek@tubitak.gov.tr>
Signed-off-by: muhsin.ozbek <muhsin.ozbek@tubitak.gov.tr>
@aliok
Copy link
Member

aliok commented Dec 6, 2023

/ok-to-test

@matejvasek
Copy link
Contributor

Why did this create thousands of files in vendor dir? I thought we removed vendor dir completely.

@matejvasek
Copy link
Contributor

I don't think we want stuff in vendor dir.

Signed-off-by: muhsin.ozbek <muhsin.ozbek@tubitak.gov.tr>
@muhsin09
Copy link
Author

muhsin09 commented Dec 6, 2023

/retest

@muhsin09
Copy link
Author

muhsin09 commented Dec 6, 2023

if we don't need stuff in vendor dir then lets add the the vendor directory to .gitignore file.

@muhsin09
Copy link
Author

muhsin09 commented Dec 6, 2023

/retest

Signed-off-by: muhsin.ozbek <muhsin.ozbek@tubitak.gov.tr>
@muhsin09
Copy link
Author

muhsin09 commented Dec 6, 2023

/retest

1 similar comment
@muhsin09
Copy link
Author

muhsin09 commented Dec 6, 2023

/retest

@matejvasek
Copy link
Contributor

verify / Verify Deps and Codegen is still failing what OS do you use?

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 7, 2023
@matejvasek
Copy link
Contributor

It appears that newer pack lib does not work all right with podman.

@matejvasek
Copy link
Contributor

@matejvasek
Copy link
Contributor

buildpacks/pack#2000

@matejvasek
Copy link
Contributor

I wish to merge this but we need to wait until pack will fix compatibility with podman.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2023
@knative-prow-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mwmahlberg
Copy link

Is there any update on this? What would need to be done?

@matejvasek
Copy link
Contributor

matejvasek commented Jan 22, 2024

@mwmahlberg I believe the next pack release (0.33.0) should contain the fix for podman.

@matejvasek
Copy link
Contributor

We just need to wait for pack release 0.33.0 and update to it because 0.32.x contain bug.

@matejvasek
Copy link
Contributor

@muhsin09 Hi there is release candidate for v0.33.0 would you mind trying to update to that?

I think you might need to apply some replace to fix transitive dependencies conflict.

replace github.com/moby/buildkit => github.com/moby/buildkit v0.11.6

@matejvasek
Copy link
Contributor

matejvasek commented Jan 31, 2024

@muhsin09 I am really sorry for slowing this PR but we must wait for pack version that does not break podman. Please let this not discourage you from contributing in future.

@matejvasek
Copy link
Contributor

@muhsin09 v0.33.0 has been released.

@matejvasek
Copy link
Contributor

superseded by #2148

@matejvasek matejvasek closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no main packages to build
5 participants