-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildpack updated to v0.32.1 #2102
Conversation
@muhsin09: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @muhsin09! It looks like this is your first PR to knative/func 🎉 |
Hi @muhsin09. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: muhsin09 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2102 +/- ##
==========================================
+ Coverage 63.90% 64.85% +0.95%
==========================================
Files 108 108
Lines 13868 13868
==========================================
+ Hits 8862 8994 +132
+ Misses 4138 3981 -157
- Partials 868 893 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retest |
Signed-off-by: muhsin.ozbek <muhsin.ozbek@tubitak.gov.tr>
/ok-to-test |
Why did this create thousands of files in vendor dir? I thought we removed vendor dir completely. |
I don't think we want stuff in vendor dir. |
Signed-off-by: muhsin.ozbek <muhsin.ozbek@tubitak.gov.tr>
/retest |
if we don't need stuff in vendor dir then lets add the the vendor directory to .gitignore file. |
/retest |
Signed-off-by: muhsin.ozbek <muhsin.ozbek@tubitak.gov.tr>
/retest |
1 similar comment
/retest |
|
Signed-off-by: Matej Vasek <mvasek@redhat.com>
It appears that newer pack lib does not work all right with |
I wish to merge this but we need to wait until |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is there any update on this? What would need to be done? |
@mwmahlberg I believe the next pack release (0.33.0) should contain the fix for podman. |
We just need to wait for pack release 0.33.0 and update to it because 0.32.x contain bug. |
@muhsin09 I am really sorry for slowing this PR but we must wait for |
superseded by #2148 |
Changes
/kind bug
Fixes #2097
Release Note
Docs