adding service account support

[nitishchauhan0022]

Changes

Added the support for additon of service account from the func cli

Fixes #1439

[codecov]

Codecov Report

Patch coverage: 59.45% and project coverage change: -2.20 ⚠️

Comparison is base (c1a90f6) 62.66% compared to head (0a018c0) 60.47%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1812      +/-   ##
==========================================
- Coverage   62.66%   60.47%   -2.20%     
==========================================
  Files         106      107       +1     
  Lines       13640    13658      +18     
==========================================
- Hits         8547     8259     -288     
- Misses       4294     4621     +327     
+ Partials      799      778      -21     

Flag	Coverage Δ
e2e-test	37.33% <59.45%> (-0.03%)	⬇️
e2e-test-oncluster	32.93% <54.05%> (-0.14%)	⬇️
e2e-test-oncluster-runtime	28.19% <48.64%> (?)
e2e-test-runtime-go	26.99% <54.05%> (?)
e2e-test-runtime-node	28.09% <54.05%> (?)
e2e-test-runtime-python	28.09% <54.05%> (?)
e2e-test-runtime-quarkus	28.21% <54.05%> (?)
e2e-test-runtime-springboot	27.14% <54.05%> (?)
e2e-test-runtime-typescript	28.21% <54.05%> (?)
integration-tests	?
unit-tests-macos-latest	49.61% <48.64%> (-0.05%)	⬇️
unit-tests-ubuntu-latest	50.38% <48.64%> (-0.05%)	⬇️
unit-tests-windows-latest	49.60% <48.64%> (-0.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/k8s/serviceaccount.go	0.00% <0.00%> (ø)
pkg/knative/deployer.go	60.84% <44.44%> (-3.42%)	⬇️
cmd/deploy.go	74.79% <100.00%> (+0.15%)	⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[lance]

/override integration-tests-latest-release_func_main
/override unit-tests_func_main
/override unit-tests_func_main

[knative-prow]

@lance: Overrode contexts on behalf of lance: integration-tests-latest-release_func_main, unit-tests_func_main

In response to this:

/override integration-tests-latest-release_func_main
/override unit-tests_func_main
/override unit-tests_func_main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lance]

Hi @nitishchauhan0022 thanks for this! Can you please run gofmt -s and also update docs/reference/func_yaml.md? Thanks!

[nitishchauhan0022]

hey @lance I have formatted the files correctly and func_yaml.md will be rebased as you mentioned.

[lkingland]

Looks good to me

CC @jrangelramos would an E2E test be difficult for this one?

/hold for other 👀

[matejvasek]

@nitishchauhan0022 please rebase.

[matejvasek]

/approve
/lgtm

[matejvasek]

@nitishchauhan0022 please rebase.

I did merge main into this PR.

[matejvasek]

/hold

[matejvasek]

PTAL @saschagrunert

[nitishchauhan0022]

@nitishchauhan0022 please rebase.

I did merge main into this PR.

Thank you @matejvasek for doing this. I was away for couple of days.

[knative-prow]

@saschagrunert: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek, nitishchauhan0022, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matejvasek]

/unhold