-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for serviceAccountName
on deploy
#1811
Conversation
@saschagrunert: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The intention of this PR is to discuss if such a feature is valuable to the community. I have a use case for it and would like to restrict the capabilities of the service without using the default service account (or modifying the service afterwards). /hold |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1811 +/- ##
==========================================
+ Coverage 62.50% 63.28% +0.78%
==========================================
Files 106 105 -1
Lines 13422 13421 -1
==========================================
+ Hits 8389 8494 +105
+ Misses 4246 4114 -132
- Partials 787 813 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, could you please also update docs? https://github.com/knative/func/blob/main/docs/reference/func_yaml.md
This allows setting the service account for the resulting knative service, which must pre-exist in the namespace to let the deployment succeed. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
bd360eb
to
d25741b
Compare
serviceAccountName
on deployserviceAccountName
on deploy
Yep done ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@saschagrunert: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@saschagrunert yes, I think this is a useful feature. It looks like someone else also wants it! #1812 I think we should merge this PR and then @nitishchauhan0022 can rebase their PR which adds a flag for it to the |
/test integration-tests-latest-release |
@saschagrunert: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
@saschagrunert isn't #1812 superset of this PR? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes, probably. :) |
/cherry-pick release-1.10 |
@lance: new pull request created: #1842 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
This allows setting the service account for the resulting knative service, which must pre-exist in the namespace to let the deployment succeed.
/kind feature
Release Note
Docs