Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added shorthand -R for --remote flag #1797

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

nitishchauhan0022
Copy link
Contributor

@nitishchauhan0022 nitishchauhan0022 commented Jun 8, 2023

Changes

Added shorthand -R for func deploy --remote flag to allow func deploy -R to work according to the Synopsis

SYNOPSIS
	{{rootCmdUse}} deploy [-R|--remote] [-r|--registry] [-i|--image] [-n|--namespace]
	             [-e|--env] [-g|--git-url] [-t|--git-branch] [-d|--git-dir]
	             [-b|--build] [--builder] [--builder-image] [-p|--push]
	             [--platform] [-c|--confirm] [-v|--verbose] [--build-timestamp]

Fixes #1719

Adds `-R` shorthand for `--remote` flag in `func deploy`

Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.04 🎉

Comparison is base (6b97fb5) 62.55% compared to head (2d7cdb4) 63.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1797      +/-   ##
==========================================
+ Coverage   62.55%   63.59%   +1.04%     
==========================================
  Files         106      106              
  Lines       13417    13417              
==========================================
+ Hits         8393     8533     +140     
+ Misses       4237     4073     -164     
- Partials      787      811      +24     
Flag Coverage Δ
e2e-test 37.71% <100.00%> (ø)
e2e-test-oncluster 33.31% <100.00%> (+0.02%) ⬆️
e2e-test-oncluster-runtime 28.60% <100.00%> (?)
e2e-test-runtime-go 27.24% <100.00%> (?)
e2e-test-runtime-node 28.40% <100.00%> (?)
e2e-test-runtime-python 28.40% <100.00%> (?)
e2e-test-runtime-quarkus 28.53% <100.00%> (?)
e2e-test-runtime-springboot 27.48% <100.00%> (?)
e2e-test-runtime-typescript 28.53% <100.00%> (?)
integration-tests 52.15% <100.00%> (+3.64%) ⬆️
unit-tests-macos-latest ?
unit-tests-ubuntu-latest 50.70% <100.00%> (+0.02%) ⬆️
unit-tests-windows-latest 49.95% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/deploy.go 75.10% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lance lance added this to the Release 1.11 milestone Jun 8, 2023
@lance
Copy link
Member

lance commented Jun 8, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2023
@lance
Copy link
Member

lance commented Jun 8, 2023

/approve

@knative-prow
Copy link

knative-prow bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, nitishchauhan0022

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
@knative-prow knative-prow bot merged commit 890d440 into knative:main Jun 9, 2023
38 checks passed
@lance
Copy link
Member

lance commented Jul 5, 2023

/cherry-pick release-1.10

@knative-prow-robot
Copy link

@lance: new pull request created: #1845

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add shorthand for 'func deploy --remote' to allow 'func deploy -R' according to the Synopsis
3 participants