Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shorthand for 'func deploy --remote' to allow 'func deploy -R' according to the Synopsis #1719

Closed
grafvonb opened this issue May 3, 2023 · 6 comments · Fixed by #1797
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor.
Milestone

Comments

@grafvonb
Copy link
Contributor

grafvonb commented May 3, 2023

According to the Synopsis of func deploy:

SYNOPSIS
	{{rootCmdUse}} deploy [-R|--remote] [-r|--registry] [-i|--image] [-n|--namespace]
	             [-e|--env] [-g|--git-url] [-t|--git-branch] [-d|--git-dir]
	             [-b|--build] [--builder] [--builder-image] [-p|--push]
	             [--platform] [-c|--confirm] [-v|--verbose] [--build-timestamp]

func deploy --remote should have a shorthand func deploy -R which is not implemented currently.

@grafvonb
Copy link
Contributor Author

grafvonb commented May 3, 2023

/assign

@grafvonb
Copy link
Contributor Author

grafvonb commented May 3, 2023

@lance Actually it is a mini-bug. How do we handle this? Should I correct it simply in the scope of #1466?

@lance
Copy link
Member

lance commented May 3, 2023

/kind bug
@grafvonb I don't think it's bad enough to need a backport. I think it should just be a simple fix.

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label May 3, 2023
@grafvonb
Copy link
Contributor Author

grafvonb commented May 3, 2023

@lance maybe a good 'good-first-issue' for a new committer?

@grafvonb
Copy link
Contributor Author

grafvonb commented May 3, 2023

/unassign

@lance
Copy link
Member

lance commented May 3, 2023

/kind good-first-issue

@knative-prow knative-prow bot added the kind/good-first-issue Denotes an issue ready for a new contributor. label May 3, 2023
@lance lance added this to the Release 1.11 milestone Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants