Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error msg when PAC is not installed #1742

Merged
merged 1 commit into from
May 17, 2023

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented May 17, 2023

Changes

  • 🧹 improve error msg when PAC is not installed

Fixes #1724

Release Note

improve error msg when PAC is not installed

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@knative-prow
Copy link

knative-prow bot commented May 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2023
@knative-prow knative-prow bot requested review from dsimansk and rhuss May 17, 2023 08:03
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.07 🎉

Comparison is base (94c81d4) 60.80% compared to head (7a063fd) 62.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1742      +/-   ##
==========================================
+ Coverage   60.80%   62.87%   +2.07%     
==========================================
  Files          94       94              
  Lines       12343    12349       +6     
==========================================
+ Hits         7505     7765     +260     
+ Misses       4149     3879     -270     
- Partials      689      705      +16     
Flag Coverage Δ
e2e-test 38.68% <0.00%> (-0.02%) ⬇️
e2e-test-oncluster 34.12% <0.00%> (-0.06%) ⬇️
e2e-test-oncluster-runtime 29.33% <0.00%> (?)
e2e-test-runtime-go 27.92% <0.00%> (?)
e2e-test-runtime-node 29.02% <0.00%> (?)
e2e-test-runtime-python 29.02% <0.00%> (?)
e2e-test-runtime-quarkus 29.15% <0.00%> (?)
e2e-test-runtime-springboot 28.07% <0.00%> (?)
e2e-test-runtime-typescript 29.15% <0.00%> (?)
integration-tests 50.15% <0.00%> (?)
unit-tests-macos-latest 48.83% <0.00%> (+<0.01%) ⬆️
unit-tests-ubuntu-latest 49.72% <0.00%> (-0.03%) ⬇️
unit-tests-windows-latest 48.89% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipelines/tekton/pipelines_pac_provider.go 4.45% <0.00%> (-0.18%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zroubalik zroubalik requested review from jrangelramos and removed request for rhuss and dsimansk May 17, 2023 08:26
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2023
@knative-prow knative-prow bot merged commit 702da8a into knative:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message on func git config set when PAC is not installed
2 participants