chore: improve error msg when PAC is not installed (#1742)

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
knative · May 17, 2023 · 702da8a · 702da8a
1 parent 9a790f0
commit 702da8a
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/pkg/pipelines/tekton/pipelines_pac_provider.go b/pkg/pipelines/tekton/pipelines_pac_provider.go
@@ -127,7 +127,11 @@ func (pp *PipelinesProvider) createClusterResources(ctx context.Context, f fn.Fu
 	// figure out pac installation namespace
 	installed, _, err := pac.DetectPACInstallation(ctx, "")
 	if !installed {
-		return fmt.Errorf("pipelines as code not installed: %w", err)
+		errMsg := ""
+		if err != nil {
+			errMsg = fmt.Sprintf(", %v", err)
+		}
+		return fmt.Errorf("pipelines as code not installed%s", errMsg)
 	}
 	if installed && err != nil {
 		return err
@@ -193,7 +197,11 @@ func (pp *PipelinesProvider) createRemoteResources(ctx context.Context, f fn.Fun
 	// figure out pac installation namespace
 	installed, installationNS, err := pac.DetectPACInstallation(ctx, "")
 	if !installed {
-		return fmt.Errorf("pipelines as code not installed: %w", err)
+		errMsg := ""
+		if err != nil {
+			errMsg = fmt.Sprintf(", %v", err)
+		}
+		return fmt.Errorf("pipelines as code not installed%s", errMsg)
 	}
 	if installed && err != nil {
 		return err