Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PaC not working with dot git suffixed URLs #1713

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Apr 28, 2023

Changes

  • 🐛 Fix PaC not working with .git suffixed URLs.

/kind bug

fixes #1707

fix: PaC not working with dot git suffixed URLs

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 28, 2023
@knative-prow knative-prow bot requested review from dsimansk and vyasgun April 28, 2023 16:26
@knative-prow
Copy link

knative-prow bot commented Apr 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek matejvasek requested review from zroubalik and removed request for dsimansk and vyasgun April 28, 2023 16:26
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.31 🎉

Comparison is base (818c5ae) 62.74% compared to head (c21b9d3) 63.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
+ Coverage   62.74%   63.05%   +0.31%     
==========================================
  Files          93       93              
  Lines       12003    12005       +2     
==========================================
+ Hits         7531     7570      +39     
+ Misses       3780     3749      -31     
+ Partials      692      686       -6     
Flag Coverage Δ
e2e-test 38.89% <0.00%> (-0.01%) ⬇️
e2e-test-oncluster 34.74% <0.00%> (+0.06%) ⬆️
e2e-test-oncluster-runtime 29.60% <0.00%> (?)
e2e-test-runtime-go 28.30% <0.00%> (?)
e2e-test-runtime-node 29.44% <0.00%> (?)
e2e-test-runtime-python 29.44% <0.00%> (?)
e2e-test-runtime-quarkus 29.57% <0.00%> (?)
e2e-test-runtime-springboot 28.36% <0.00%> (?)
e2e-test-runtime-typescript 29.57% <0.00%> (?)
integration-tests 50.00% <100.00%> (-0.03%) ⬇️
unit-tests-macos-latest 48.82% <100.00%> (+<0.01%) ⬆️
unit-tests-ubuntu-latest 49.73% <100.00%> (+<0.01%) ⬆️
unit-tests-windows-latest 48.90% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/git/git.go 74.28% <100.00%> (+1.55%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@jrangelramos
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2023
@knative-prow knative-prow bot merged commit f2eb853 into knative:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PaC with GitHub not working with the .git suffixed form
2 participants