fix: PaC not working with dot git suffixed url

Signed-off-by: Matej Vasek <mvasek@redhat.com>
knative · Apr 28, 2023 · 6c81499 · 6c81499
1 parent cd0dbfd
commit 6c81499
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/pkg/git/git.go b/pkg/git/git.go
@@ -61,5 +61,7 @@ func RepoOwnerAndNameFromUrl(url string) (string, string, error) {
 	repoOwner := repoArr[0]
 	repoName := repoArr[1]
 
+	repoName = strings.TrimSuffix(repoName, ".git")
+
 	return repoOwner, repoName, nil
 }
diff --git a/pkg/git/git_test.go b/pkg/git/git_test.go
@@ -17,6 +17,13 @@ func TestGetRepoOwnerFromGHURL(t *testing.T) {
 			wantName:  "bar",
 			wantErr:   false,
 		},
+		{
+			name:      "correct with dot git suffix",
+			url:       "https://gh/foo/bar.git",
+			wantOwner: "foo",
+			wantName:  "bar",
+			wantErr:   false,
+		},
 		{
 			name:      "correct with capital letters",
 			url:       "https://gh/FOO/bar",