Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust templates dependencies and UTs for Actix 4.x #1661

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

andrejusc
Copy link
Contributor

Changes

  • Updated Rust dependencies to latest for Rust templates
  • As Actix FW got updated to 4.3.1 - adjusted involved UTs
  • Added primitive .gitignore to avoid target/ from commit

/kind enhancement

Fixes #

Release Note

Update Rust templates dependencies and UTs for Actix 4.x

Docs


@knative-prow knative-prow bot requested review from dsimansk and rhuss March 31, 2023 11:35
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.22 🎉

Comparison is base (1ce5d2b) 62.71% compared to head (b191101) 62.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1661      +/-   ##
==========================================
+ Coverage   62.71%   62.94%   +0.22%     
==========================================
  Files          93       93              
  Lines       11939    11939              
==========================================
+ Hits         7488     7515      +27     
+ Misses       3770     3746      -24     
+ Partials      681      678       -3     
Flag Coverage Δ
e2e-test 38.85% <ø> (ø)
e2e-test-oncluster 34.61% <ø> (-0.08%) ⬇️
e2e-test-oncluster-runtime 29.53% <ø> (?)
e2e-test-runtime-go 28.13% <ø> (?)
e2e-test-runtime-node 29.37% <ø> (?)
e2e-test-runtime-python 29.27% <ø> (?)
e2e-test-runtime-quarkus 29.50% <ø> (?)
e2e-test-runtime-springboot 28.39% <ø> (?)
e2e-test-runtime-typescript 29.50% <ø> (?)
integration-tests 49.44% <ø> (+0.04%) ⬆️
unit-tests-macos-latest 48.21% <ø> (ø)
unit-tests-ubuntu-latest 49.14% <ø> (+0.02%) ⬆️
unit-tests-windows-latest 48.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrejusc
Copy link
Contributor Author

@matejvasek - maybe you could help me today with this PR as well? Thank you

@matejvasek
Copy link
Contributor

/approve
/lgmt

@knative-prow
Copy link

knative-prow bot commented Mar 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrejusc, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2023
@andrejusc
Copy link
Contributor Author

@dsimansk - how it looks for you?

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2023
@knative-prow knative-prow bot merged commit c6c0f7e into knative:main Mar 31, 2023
@andrejusc
Copy link
Contributor Author

@matejvasek - thank you for help. Could we cut some new release with yesterday's/today's changes included? Or more PRs need to accumulate first for release justification?

@matejvasek
Copy link
Contributor

@andrejusc
Copy link
Contributor Author

@matejvasek - what I meant to say - next 1.9.x release of this func, potentially 1.9.3 at the moment and then that to be picked up as kn-func plugin into overall kn tool. How is that flow handled?

@matejvasek
Copy link
Contributor

@matejvasek - what I meant to say - next 1.9.x release of this func, potentially 1.9.3 at the moment and then that to be picked up as kn-func plugin into overall kn tool. How is that flow handled?

/cc @lance

@knative-prow knative-prow bot requested a review from lance March 31, 2023 19:40
@lance
Copy link
Member

lance commented Mar 31, 2023

@matejvasek @andrejusc I will create a cherry-pick PR for this on the 1.9 branch. That should cause 1.9.3 to land next Tuesday.

@andrejusc
Copy link
Contributor Author

@lance - thank you for clarification. Please cherry-pick into 1.9 branch also another already merged PR #1658

knative-prow bot pushed a commit that referenced this pull request Mar 31, 2023
…1663)

* Update Rust templates dependencies and UTs for Actix 4.x (#1661)

* Update springboot templates to Spring Boot 3.0.5 (#1658)

* Update springboot templates to Spring Boot 3.0.5

* Regenerated embedded file

* Regenerated embedded file one more time

---------

Co-authored-by: Andrejus Chaliapinas <andrejusc@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants