Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update springboot templates to Spring Boot 3.0.5 #1658

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

andrejusc
Copy link
Contributor

@andrejusc andrejusc commented Mar 30, 2023

Changes

  • Updated Spring Boot version from 3.0.2 to latest stable 3.0.5
  • Updated Spring Cloud version from 2022.0.0 to latest stable 2022.0.2
  • Made Maven compiler plugin to use latest version 3.11.0
  • Made Maven surefire plugin (used for tests) to use latest version 3.0.0
  • Updated Maven wrapper definition to utilize latest 3.9.1

/kind enhancement

Fixes #

Release Note

Update springboot templates to Spring Boot 3.0.5

Docs


@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 30, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow
Copy link

knative-prow bot commented Mar 30, 2023

Welcome @andrejusc! It looks like this is your first PR to knative/func 🎉

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 30, 2023
@knative-prow knative-prow bot requested review from maximilien and rhuss March 30, 2023 14:59
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.09 🎉

Comparison is base (1095ede) 60.67% compared to head (c1f0d56) 62.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1658      +/-   ##
==========================================
+ Coverage   60.67%   62.77%   +2.09%     
==========================================
  Files          93       93              
  Lines       11961    11961              
==========================================
+ Hits         7257     7508     +251     
+ Misses       4033     3765     -268     
- Partials      671      688      +17     
Flag Coverage Δ
e2e-test 38.70% <ø> (-0.03%) ⬇️
e2e-test-oncluster 34.45% <ø> (?)
e2e-test-oncluster-runtime 29.40% <ø> (?)
e2e-test-runtime-go 28.04% <ø> (?)
e2e-test-runtime-node 29.20% <ø> (?)
e2e-test-runtime-python 29.24% <ø> (?)
e2e-test-runtime-quarkus 29.34% <ø> (?)
e2e-test-runtime-springboot 28.26% <ø> (?)
e2e-test-runtime-typescript 29.37% <ø> (?)
integration-tests 49.28% <ø> (+0.03%) ⬆️
unit-tests-macos-latest 48.04% <ø> (ø)
unit-tests-ubuntu-latest 48.99% <ø> (ø)
unit-tests-windows-latest 47.98% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrejusc
Copy link
Contributor Author

/retest

@knative-prow
Copy link

knative-prow bot commented Mar 30, 2023

@andrejusc: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrejusc
Copy link
Contributor Author

@rhuss - I'm a newbie here in terms of PR. Could you help me to understand why Integration test is failing? I don't see anything obvious in produced output.

@andrejusc
Copy link
Contributor Author

I've tried above failed Func Integration Test on my fork and it passed for exact same PR. So looks to me some intermittent issue here.

@matejvasek
Copy link
Contributor

@andrejusc just some temporary error I guess, let me re-run tests.

@matejvasek matejvasek requested review from matejvasek and removed request for maximilien and rhuss March 30, 2023 21:30
@andrejusc
Copy link
Contributor Author

@matejvasek - thank you, now re-run passed. So I think this could be merged then, could you do that?

@matejvasek
Copy link
Contributor

/approve
/lgtm

@andrejusc Thanks for the contribution!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2023
@knative-prow
Copy link

knative-prow bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrejusc, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2023
@knative-prow knative-prow bot merged commit 79430e9 into knative:main Mar 30, 2023
lance pushed a commit to lance/func that referenced this pull request Mar 31, 2023
* Update springboot templates to Spring Boot 3.0.5

* Regenerated embedded file

* Regenerated embedded file one more time
knative-prow bot pushed a commit that referenced this pull request Mar 31, 2023
…1663)

* Update Rust templates dependencies and UTs for Actix 4.x (#1661)

* Update springboot templates to Spring Boot 3.0.5 (#1658)

* Update springboot templates to Spring Boot 3.0.5

* Regenerated embedded file

* Regenerated embedded file one more time

---------

Co-authored-by: Andrejus Chaliapinas <andrejusc@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants