-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update springboot templates to Spring Boot 3.0.5 #1658
Update springboot templates to Spring Boot 3.0.5 #1658
Conversation
|
Welcome @andrejusc! It looks like this is your first PR to knative/func 🎉 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1658 +/- ##
==========================================
+ Coverage 60.67% 62.77% +2.09%
==========================================
Files 93 93
Lines 11961 11961
==========================================
+ Hits 7257 7508 +251
+ Misses 4033 3765 -268
- Partials 671 688 +17
Flags with carried forward coverage won't be shown. Click here to find out more. see 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
/retest |
@andrejusc: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rhuss - I'm a newbie here in terms of PR. Could you help me to understand why Integration test is failing? I don't see anything obvious in produced output. |
I've tried above failed Func Integration Test on my fork and it passed for exact same PR. So looks to me some intermittent issue here. |
@andrejusc just some temporary error I guess, let me re-run tests. |
@matejvasek - thank you, now re-run passed. So I think this could be merged then, could you do that? |
/approve @andrejusc Thanks for the contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrejusc, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update springboot templates to Spring Boot 3.0.5 * Regenerated embedded file * Regenerated embedded file one more time
…1663) * Update Rust templates dependencies and UTs for Actix 4.x (#1661) * Update springboot templates to Spring Boot 3.0.5 (#1658) * Update springboot templates to Spring Boot 3.0.5 * Regenerated embedded file * Regenerated embedded file one more time --------- Co-authored-by: Andrejus Chaliapinas <andrejusc@yahoo.com>
Changes
/kind enhancement
Fixes #
Release Note
Docs