Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] unit test only #1642

Closed
wants to merge 2 commits into from

Conversation

jrangelramos
Copy link
Contributor

do not merge. test only

@knative-prow knative-prow bot requested a review from navidshaikh March 21, 2023 19:47
@knative-prow
Copy link

knative-prow bot commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from rhuss March 21, 2023 19:47
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2023
@jrangelramos jrangelramos requested review from matejvasek and removed request for rhuss and navidshaikh March 21, 2023 19:49
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +8.05 🎉

Comparison is base (7c724bc) 54.79% compared to head (d7c0f45) 62.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
+ Coverage   54.79%   62.84%   +8.05%     
==========================================
  Files          92       93       +1     
  Lines       11909    11911       +2     
==========================================
+ Hits         6525     7485     +960     
+ Misses       4781     3741    -1040     
- Partials      603      685      +82     
Flag Coverage Δ
e2e-test 38.82% <ø> (?)
e2e-test-oncluster 34.52% <ø> (-0.08%) ⬇️
e2e-test-oncluster-runtime 29.45% <ø> (?)
e2e-test-runtime-go 28.15% <ø> (?)
e2e-test-runtime-node 29.29% <ø> (?)
e2e-test-runtime-python 29.29% <ø> (?)
e2e-test-runtime-quarkus 29.43% <ø> (?)
e2e-test-runtime-springboot 28.31% <ø> (?)
e2e-test-runtime-typescript 29.43% <ø> (?)
integration-tests 49.33% <ø> (?)
unit-tests-macos-latest 48.08% <ø> (?)
unit-tests-ubuntu-latest 49.04% <ø> (?)
unit-tests-windows-latest 47.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matejvasek
Copy link
Contributor

Coverage +8.05 🤣 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants