-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: s2i python build on Windows #1641
Conversation
Make all files executable on Windows s2i build. Signed-off-by: Matej Vasek <mvasek@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1641 +/- ##
==========================================
- Coverage 54.79% 51.12% -3.67%
==========================================
Files 92 92
Lines 11909 11913 +4
==========================================
- Hits 6525 6091 -434
- Misses 4781 5270 +489
+ Partials 603 552 -51
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@jrangelramos does this work? |
@lance please override the Lint. |
@lance maybe we have a time to backport this? |
/override "style / Golang / Lint" |
@kvmware: Overrode contexts on behalf of kvmware: style / Golang / Lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cherry-pick release-1.9 |
@lance: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Overriding all of the style checks since this is basically a one-liner. /override "style / suggester / shell" |
@lance: Overrode contexts on behalf of lance: style / suggester / github_actions, style / suggester / shell, style / suggester / yaml In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
it works on Windows! |
I have absolutely on idea why that one test is failing. |
It seems to be related to this recent change https://github.com/knative/func/pull/1631/files#diff-12756d69e272b512547442b82be9dee485eff66dbce9705b46c164f2c814b00eL17 I just tried a PR (using new previous actions) to confirm #1642 |
Thanks for looking into this @jrangelramos - we should bubble this up to @knative/productivity-leads |
Even that is confusing though. Going back to the last SHA that had
diff go-test.yaml reusable-go-test.yaml
62c62
< run: echo 'COVER_OPTS=-coverprofile=coverage.txt -covermode=atomic' >> $GITHUB_ENV
---
> run: echo 'COVER_OPTS=-coverprofile=coverage.txt -covermode=atomic' >> "$GITHUB_ENV"
65c65
< run: go test -race $COVER_OPTS ./...
---
> run: go test -race "$COVER_OPTS ./..." |
@lance please just override the test |
/override "test / Unit Tests" |
@lance: Overrode contexts on behalf of lance: test / Unit Tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lance: #1641 failed to apply on top of branch "release-1.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
/kind bug