fix: node s2i build when node_modules present #1612
Merged
Commits on Mar 9, 2023
-
fix: node s2i build when node_modules present
This is workaround for two bug in another components: * The s2i CLI/library is not honoring the `--exclude` flag when used with the `--as-dockerfile` flag. * The node s2i image is not working if project contains `node_modules` directory with NodeJS modules. If only one of the bugs above were fixed this commit wouldn't be necessary. Signed-off-by: Matej Vasek <mvasek@redhat.com>
-
fix: project root escape link detection
Signed-off-by: Matej Vasek <mvasek@redhat.com>
-
fix: ignore node_modules for s2i on cluster build
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.