-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: node s2i build when node_modules present #1612
fix: node s2i build when node_modules present #1612
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1612 +/- ##
===========================================
+ Coverage 49.55% 63.69% +14.14%
===========================================
Files 80 92 +12
Lines 10760 11600 +840
===========================================
+ Hits 5332 7389 +2057
+ Misses 4964 3540 -1424
- Partials 464 671 +207
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 55 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
e521d72
to
faae74b
Compare
This is workaround for two bug in another components: * The s2i CLI/library is not honoring the `--exclude` flag when used with the `--as-dockerfile` flag. * The node s2i image is not working if project contains `node_modules` directory with NodeJS modules. If only one of the bugs above were fixed this commit wouldn't be necessary. Signed-off-by: Matej Vasek <mvasek@redhat.com>
faae74b
to
a8a36e9
Compare
@zroubalik @lkingland PTAL |
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
🐛 Fix NodeJS s2i build when
node_modules
is present on filesystem.This is workaround for two bug in another components:
--exclude
flag when used with the--as-dockerfile
flag.The
--exclude
flag is not used in--as-dockerfile
mode. openshift/source-to-image#1104node_modules
directory with NodeJS modules.Run fails when project contains
node_modules
directory. sclorg/s2i-nodejs-container#333If only one of the bugs above were fixed this PR wouldn't be necessary.
/kind bug