-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: build stamp computation #1608
Conversation
About the same time that buildStamp was computed .gitignore was modified. This caused non-deterministic results, because sometimes the modification was taken into account and sometimed it was not. Signed-off-by: Matej Vasek <mvasek@redhat.com>
@lkingland @zroubalik PTAL |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1608 +/- ##
==========================================
- Coverage 58.66% 56.88% -1.78%
==========================================
Files 82 92 +10
Lines 10884 11584 +700
==========================================
+ Hits 6385 6590 +205
- Misses 3903 4387 +484
- Partials 596 607 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@lkingland why is |
It is currently ensured during project creation. It is not tracked in source control (this is the purpose of the directory), so any code which requires it to exist needs to call |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
About the same time that
buildStamp
was computed.gitignore
was (unnecessary) modified.This caused timestamp mismatch so function appeared to be not built.
Reason: sometimes (randomly) the
buildStamp
was computed before the.gitignore
was modified./kind bug