-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pvc-size flag to deploy command (#851) #1598
feat: add pvc-size flag to deploy command (#851) #1598
Conversation
Getting currently a little bit strange panic during an old UT (in previous version it was ok):
Needs investigation. |
0ca47cd
to
944b0b3
Compare
4974ef3
to
42ab2f3
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1598 +/- ##
==========================================
+ Coverage 62.71% 62.93% +0.21%
==========================================
Files 93 93
Lines 11939 11955 +16
==========================================
+ Hits 7488 7524 +36
+ Misses 3770 3751 -19
+ Partials 681 680 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Something is wrong with build timestamps. |
|
It appears that build sets buildStamp at the end of build but it simultaneously creates .gitignore (which affects final stamp). There is apparently some race because sometimes the modified .gitignore is taken into account and sometime is's not. I don't see how this PR is causing this. |
See #1608 |
afd28a0
to
998071e
Compare
@grafvonb Now I see similar issue is happening with |
In deploy step we are updating |
Can I re-run the pipeline without changing anything or faking with |
I suppose you could, or you could add empty commit. But I don't think it will pass. If it was single test then maybe, but there are multiple and do not think that odds are high that all test will pass. |
@grafvonb what is weird is that this happens for this PR. We should see it on pretty much all PRs. |
Could you look into it more closely? |
3a27f1c
to
55734a7
Compare
55734a7
to
f4a2ec9
Compare
/approve |
@lance @matejvasek I rebased the commits again and resolved all conflicts. Can we maybe finalize this soon? Since my change touches |
d7c32b6
to
af9a246
Compare
"Analyse" check fails due to:
@matejvasek Who can repair this? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grafvonb, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ref: #851
Second try, after recreating the changes on the new project structure (old PR: #1543)