Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src!: change all references of "repository" to "registry" for images #156

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

lance
Copy link
Member

@lance lance commented Oct 6, 2020

When dealing with images, instead of referring to an image repository,
let's use the more correct term "registry", even though we're actually
using "registry/namespace" in most cases.

Fixes: #154

Signed-off-by: Lance Ball lball@redhat.com

Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit in Function.go

function.go Outdated Show resolved Hide resolved
@lance
Copy link
Member Author

lance commented Oct 7, 2020

LGTM, minor nit in Function.go

I just missed this one. My search was usually for /repository/i.

When dealing with images, instead of referring to an image repository,
let's instead use the more correct term "registry", even though we're
actually using "registry/namespace" in most case.

Signed-off-by: Lance Ball <lball@redhat.com>
@lance
Copy link
Member Author

lance commented Oct 7, 2020

@zroubalik I have merged your changes and rebased. PTAL

Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit e425c8f into knative:main Oct 8, 2020
This was referenced Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change FAAS_REPOSITORY to FAAS_REGISTRY
2 participants