Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FAAS_REPOSITORY to FAAS_REGISTRY #154

Closed
lance opened this issue Oct 6, 2020 · 1 comment · Fixed by #156
Closed

Change FAAS_REPOSITORY to FAAS_REGISTRY #154

lance opened this issue Oct 6, 2020 · 1 comment · Fixed by #156
Assignees

Comments

@lance
Copy link
Member

lance commented Oct 6, 2020

I think probably it makes sense as @rhuss suggested, to change FAAS_REPOSITORY to FAAS_REGISTRY since that's really what we are asking for anyway (terminology in this space is so messy).

A simple Quarkus project faas.yaml looks like this:

name: quarkus
namespace: ""
runtime: quarkus
image: docker.io/lanceball/quarkus:latest
trigger: events
builder: default
builderMap:
  default: quay.io/boson/faas-quarkus-jvm-builder
  jvm: quay.io/boson/faas-quarkus-jvm-builder
  native: quay.io/boson/faas-quarkus-native-builder

Instead, I think the image property should just be quarkus:latest and that we should persist the FAAS_REGISTRY value in this file as well.

/cc @boson-project/core

@lance
Copy link
Member Author

lance commented Oct 6, 2020

Alternatively, we could get rid of FAAS_IMAGE and instead keep FAAS_REPOSITORY but have it point to the full image, meaning registry/[user]/<repository>:[tag] (where [user] and [tag] are optional (since a registry may not expose repos in a namespace and tag could just be latest).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant