Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds refspec support for func repo add #1558

Merged
merged 6 commits into from
Feb 16, 2023

Conversation

lance
Copy link
Member

@lance lance commented Feb 15, 2023

Changes

  • 🎁 adds support for a git refspec, such as a branch or tag to the repository URL in func repo add <url> by accepting refspec values after a hashtag in the URL, for example: https://github.com/knative-sandbox/func-tastic#work-in-progress.

/kind enhancement

Fixes: #1197
Closes: #1287

Release Note

adds support for branches and tags when adding a template repository using `func repository add <uri>`

daisy-ycguo and others added 4 commits February 15, 2023 13:09
Signed-off-by: Knative Automation <automation@knative.team>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Removes the currently in-flight work on the `--branch` tag, simply
supporting a `refspec` on the repository URI. For example,
https://github.com/knative-sandbox/func-tastic#metacontroller will pull
the `func-tastic` repo, and set the currently active HEAD to the
`metacontroller` branch. Adds support for displaying this with the
command `func repo list -v`.

Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow knative-prow bot added kind/enhancement approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2023
Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance added this to the Release 1.10 milestone Feb 15, 2023
Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 60.28% // Head: 60.61% // Increases project coverage by +0.33% 🎉

Coverage data is based on head (a4bf35a) compared to base (5a4803b).
Patch coverage: 63.41% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1558      +/-   ##
==========================================
+ Coverage   60.28%   60.61%   +0.33%     
==========================================
  Files          75       76       +1     
  Lines       10214    10243      +29     
==========================================
+ Hits         6157     6209      +52     
+ Misses       3489     3465      -24     
- Partials      568      569       +1     
Flag Coverage Δ
integration-tests 50.93% <58.53%> (+0.03%) ⬆️
unit-tests ?
unit-tests-macos-latest 49.37% <63.41%> (?)
unit-tests-ubuntu-latest 50.87% <63.41%> (?)
unit-tests-windows-latest 49.24% <63.41%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/functions/repository.go 70.24% <40.00%> (-2.72%) ⬇️
cmd/repository.go 57.25% <100.00%> (+0.68%) ⬆️
pkg/docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
pkg/functions/client.go 59.21% <0.00%> (+0.55%) ⬆️
pkg/docker/creds/credentials.go 73.06% <0.00%> (+1.34%) ⬆️
pkg/knative/logs.go 84.53% <0.00%> (+4.12%) ⬆️
pkg/docker/docker_client.go 84.87% <0.00%> (+23.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a winner to me

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 44bb13f into knative:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add support for named branches in func repository add command
5 participants