-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds refspec support for func repo add
#1558
Conversation
Signed-off-by: Knative Automation <automation@knative.team>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Removes the currently in-flight work on the `--branch` tag, simply supporting a `refspec` on the repository URI. For example, https://github.com/knative-sandbox/func-tastic#metacontroller will pull the `func-tastic` repo, and set the currently active HEAD to the `metacontroller` branch. Adds support for displaying this with the command `func repo list -v`. Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
Codecov ReportBase: 60.28% // Head: 60.61% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1558 +/- ##
==========================================
+ Coverage 60.28% 60.61% +0.33%
==========================================
Files 75 76 +1
Lines 10214 10243 +29
==========================================
+ Hits 6157 6209 +52
+ Misses 3489 3465 -24
- Partials 568 569 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a winner to me
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
func repo add <url>
by accepting refspec values after a hashtag in the URL, for example:https://github.com/knative-sandbox/func-tastic#work-in-progress
./kind enhancement
Fixes: #1197
Closes: #1287
Release Note