Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Format Go code #1407

Merged

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Nov 3, 2022

Cron -knative-prow-robot

/cc knative/func-approvers
/assign knative/func-approvers

Produced by: knative-sandbox/knobots/actions/update-gofmt

Details:

 

Signed-off-by: Knative Automation <automation@knative.team>
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 62.15% // Head: 62.46% // Increases project coverage by +0.30% 🎉

Coverage data is based on head (af019b6) compared to base (ea79cf0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1407      +/-   ##
==========================================
+ Coverage   62.15%   62.46%   +0.30%     
==========================================
  Files          74       75       +1     
  Lines       10712    10714       +2     
==========================================
+ Hits         6658     6692      +34     
+ Misses       3495     3465      -30     
+ Partials      559      557       -2     
Flag Coverage Δ
integration-tests 52.22% <ø> (-0.01%) ⬇️
unit-tests ?
unit-tests-macos-latest 52.54% <ø> (?)
unit-tests-ubuntu-latest 53.92% <ø> (?)
unit-tests-windows-latest 52.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/deploy.go 63.78% <ø> (ø)
config/config.go 82.19% <ø> (ø)
k8s/dialer.go 73.33% <ø> (ø)
repository.go 72.69% <ø> (ø)
knative/deployer.go 61.55% <0.00%> (-0.17%) ⬇️
docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
client.go 63.75% <0.00%> (+0.62%) ⬆️
docker/creds/credentials.go 73.06% <0.00%> (+1.34%) ⬆️
docker/docker_client.go 84.87% <0.00%> (+23.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2022
@knative-prow
Copy link

knative-prow bot commented Nov 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2022
@knative-prow knative-prow bot merged commit 5d67de7 into knative:main Nov 4, 2022
lance pushed a commit to lance/func that referenced this pull request Feb 15, 2023
Signed-off-by: Knative Automation <automation@knative.team>
lance pushed a commit to lance/func that referenced this pull request Feb 15, 2023
Signed-off-by: Knative Automation <automation@knative.team>
knative-prow bot pushed a commit that referenced this pull request Feb 16, 2023
* add option 'branch' to command 'repository add'

* Format go code (#1407)

Signed-off-by: Knative Automation <automation@knative.team>

* chore: refactor repository layout (#1554)

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

* fixup: removes --branch tag from repo commands

Removes the currently in-flight work on the `--branch` tag, simply
supporting a `refspec` on the repository URI. For example,
https://github.com/knative-sandbox/func-tastic#metacontroller will pull
the `func-tastic` repo, and set the currently active HEAD to the
`metacontroller` branch. Adds support for displaying this with the
command `func repo list -v`.

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: add example to `func repo add` documentation

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: adjust test output expectations

Signed-off-by: Lance Ball <lball@redhat.com>

---------

Signed-off-by: Knative Automation <automation@knative.team>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Lance Ball <lball@redhat.com>
Co-authored-by: Yingchun Guo <yingchun.guo@intel.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants