-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove underscore prefix from test packages #1503
chore: remove underscore prefix from test packages #1503
Conversation
Codecov ReportBase: 63.03% // Head: 63.32% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1503 +/- ##
==========================================
+ Coverage 63.03% 63.32% +0.28%
==========================================
Files 74 75 +1
Lines 10768 10770 +2
==========================================
+ Hits 6788 6820 +32
+ Misses 3421 3394 -27
+ Partials 559 556 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
f630d7d
to
6e9c2f5
Compare
7dd95b6
to
678f64a
Compare
/lgtm |
Thanks for going thru this @lkingland |
678f64a
to
1be847b
Compare
@trisberg any idea why
would happen? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
<compiler-plugin.version>3.10.1</compiler-plugin.version> | ||
<spring-cloud.version>2021.0.3</spring-cloud.version> | ||
<spring-native.version>0.12.1</spring-native.version> | ||
<compiler-plugin.version>3.8.1</compiler-plugin.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lkingland the PR overall is great - thanks! Just curious why we are downgrading here.
* remove underscore prefix from test packages * springboot patch attempt
Changes
The underscore causes various problems, such as in IDE autocomplete and code analys tasks, because this underscore instructs go tooling to ignore the package. The original purpose of this obfuscation was to work around a CI/CD problem which is no longer affecting us; so this PR removes the workaround.
/kind cleanup
Release Note