chore: remove underscore prefix from test packages #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
do-not-merge/work-in-progress
knative-prow
bot
added
the
approved
lkingland
requested review from
jrangelramos
and removed request for
dsimansk and
nainaz
knative-prow
bot
added
the
size/M
knative-prow
bot
removed
the
do-not-merge/work-in-progress
Codecov ReportBase: 63.03% // Head: 63.32% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1503 +/- ##
==========================================
+ Coverage 63.03% 63.32% +0.28%
==========================================
Files 74 75 +1
Lines 10768 10770 +2
==========================================
+ Hits 6788 6820 +32
+ Misses 3421 3394 -27
+ Partials 559 556 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lkingland
force-pushed
the
lkingland/e2e-test-package-rename
branch
from
f630d7d
to
6e9c2f5
Compare
knative-prow
bot
added
size/XXL
lkingland
force-pushed
the
lkingland/e2e-test-package-rename
branch
from
7dd95b6
to
678f64a
Compare
knative-prow
bot
added
size/L
|
/lgtm |
|
Thanks for going thru this @lkingland |
lkingland
force-pushed
the
lkingland/e2e-test-package-rename
branch
from
678f64a
to
1be847b
Compare
|
@trisberg any idea why would happen? |
knative-prow
bot
removed
the
size/L
knative-prow
bot
added
the
size/XL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lance
reviewed
Jan 20, 2023
| <compiler-plugin.version>3.10.1</compiler-plugin.version> | ||
| <spring-cloud.version>2021.0.3</spring-cloud.version> | ||
| <spring-native.version>0.12.1</spring-native.version> | ||
| <compiler-plugin.version>3.8.1</compiler-plugin.version> |
There was a problem hiding this comment.
@lkingland the PR overall is great - thanks! Just curious why we are downgrading here.
lance
pushed a commit
to lance/func
that referenced
this pull request
Feb 15, 2023
* remove underscore prefix from test packages * springboot patch attempt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The underscore causes various problems, such as in IDE autocomplete and code analys tasks, because this underscore instructs go tooling to ignore the package. The original purpose of this obfuscation was to work around a CI/CD problem which is no longer affecting us; so this PR removes the workaround.
/kind cleanup
Release Note