Skip to content

Commit

Permalink
remove underscore prefix from test packages
Browse files Browse the repository at this point in the history
  • Loading branch information
lkingland committed Jan 18, 2023
1 parent d3d3233 commit f630d7d
Show file tree
Hide file tree
Showing 61 changed files with 19 additions and 19 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ test: $(CODE) ## Run core unit tests

check: bin/golangci-lint ## Check code quality (lint)
./bin/golangci-lint run --timeout 300s
cd test/_e2e && ../../bin/golangci-lint run --timeout 300s
cd test/e2e && ../../bin/golangci-lint run --timeout 300s

bin/golangci-lint:
curl -sSfL https://github.com/raw/golangci/golangci-lint/master/install.sh | sh -s -- -b ./bin v1.49.0
Expand Down
2 changes: 1 addition & 1 deletion test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ other scenarios.
## On Cluster Builds tests

On cluster builds e2e tests exercises functions built directly on cluster.
The tests are organized per scenarios under `./_oncluster` folder.
The tests are organized per scenarios under `./oncluster` folder.

### Pre-requisites

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion test/_common/gitserver.go → test/common/gitserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"context"

"knative.dev/func/k8s"
e2e "knative.dev/func/test/_e2e"
e2e "knative.dev/func/test/e2e"

"strings"
"testing"
Expand Down
2 changes: 1 addition & 1 deletion test/_common/knfunc.go → test/common/knfunc.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package common
import (
"testing"

e2e "knative.dev/func/test/_e2e"
e2e "knative.dev/func/test/e2e"
)

func NewKnFuncShellCli(t *testing.T) *TestExecCmd {
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion test/e2e_extended_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ fi
export E2E_FUNC_BIN_PATH=$(pwd)/func

go clean -testcache
go test -v -test.v -tags="e2e" ./test/_e2e/
go test -v -test.v -tags="e2e" ./test/e2e/
ret=$?

cd $curdir
Expand Down
2 changes: 1 addition & 1 deletion test/e2e_lifecycle_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ fi
export E2E_FUNC_BIN_PATH=$(pwd)/func

go clean -testcache
go test -v -test.v -test.timeout=45m -tags="e2elc" ./test/_e2e/
go test -v -test.v -test.timeout=45m -tags="e2elc" ./test/e2e/
ret=$?

cd $curdir
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"testing"

fn "knative.dev/func"
common "knative.dev/func/test/_common"
common "knative.dev/func/test/common"
)

// UpdateFuncGit updates a function's git settings
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import (

"gotest.tools/v3/assert"
"k8s.io/apimachinery/pkg/util/rand"
common "knative.dev/func/test/_common"
e2e "knative.dev/func/test/_e2e"
common "knative.dev/func/test/common"
e2e "knative.dev/func/test/e2e"
)

// TestBasicUpload check if direct source upload works
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import (

"gotest.tools/v3/assert"
"k8s.io/apimachinery/pkg/util/rand"
common "knative.dev/func/test/_common"
e2e "knative.dev/func/test/_e2e"
common "knative.dev/func/test/common"
e2e "knative.dev/func/test/e2e"
)

// TestContextDirFunc tests the following use case:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (

"k8s.io/apimachinery/pkg/util/rand"
fn "knative.dev/func"
common "knative.dev/func/test/_common"
e2e "knative.dev/func/test/_e2e"
common "knative.dev/func/test/common"
e2e "knative.dev/func/test/e2e"
)

// TestFromCliBuildLocal tests the scenario which func.yaml indicates that builds should be on cluster
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ import (

"gotest.tools/v3/assert"
"k8s.io/apimachinery/pkg/util/rand"
common "knative.dev/func/test/_common"
e2e "knative.dev/func/test/_e2e"
common "knative.dev/func/test/common"
e2e "knative.dev/func/test/e2e"
)

// TestFromCliDefaultBranch triggers a default branch test by using CLI flags
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ import (

"k8s.io/apimachinery/pkg/util/rand"
fn "knative.dev/func"
common "knative.dev/func/test/_common"
e2e "knative.dev/func/test/_e2e"
common "knative.dev/func/test/common"
e2e "knative.dev/func/test/e2e"
)

func TestFromFeatureBranch(t *testing.T) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import (
"testing"

"k8s.io/apimachinery/pkg/util/rand"
common "knative.dev/func/test/_common"
e2e "knative.dev/func/test/_e2e"
common "knative.dev/func/test/common"
e2e "knative.dev/func/test/e2e"
)

var runtimeSupportMap = map[string][]string{
Expand Down
File renamed without changes.

0 comments on commit f630d7d

Please sign in to comment.