-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deploy command global config with function context #1434
Merged
knative-prow
merged 18 commits into
knative:main
from
lkingland:lkingland/deploy-global-config
Feb 6, 2023
Merged
feat: deploy command global config with function context #1434
knative-prow
merged 18 commits into
knative:main
from
lkingland:lkingland/deploy-global-config
Feb 6, 2023
Commits on Feb 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0df4a62 - Browse repository at this point
Copy the full SHA 0df4a62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a19960 - Browse repository at this point
Copy the full SHA 5a19960View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64e5a0a - Browse repository at this point
Copy the full SHA 64e5a0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07b53eb - Browse repository at this point
Copy the full SHA 07b53ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32720e2 - Browse repository at this point
Copy the full SHA 32720e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 832982c - Browse repository at this point
Copy the full SHA 832982cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab162db - Browse repository at this point
Copy the full SHA ab162dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 70c1490 - Browse repository at this point
Copy the full SHA 70c1490View commit details -
Configuration menu - View commit details
-
Copy full SHA for 039ab42 - Browse repository at this point
Copy the full SHA 039ab42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38b1eec - Browse repository at this point
Copy the full SHA 38b1eecView commit details -
Improved Namespace calculation and Caching
- Built() now a client package function - Namespace evaluation delegeate to implementations This enables the func.yaml to avert dirtiness checks on rebuilds (caching) - Build and Deploy update build stamp on completion Enables dirtiness checks to be unaffects, leading to better caching. - CLI Namespace checks no longer require k8s env evaluation for default - Fixed missing condition check in TestDeploy_Namespace - Fixes some minor linter and spelling errors - Global config does not directly set namespace - it is corrected to be deferred evaluation used by implementations. - Skips writing func.yaml on f.Write if there were no modifications, which leads to better caching (no timestamp update means Built == true) - HasImage removed in favor of a corrected fn.Built
Configuration menu - View commit details
-
Copy full SHA for 7c80431 - Browse repository at this point
Copy the full SHA 7c80431View commit details -
Configuration menu - View commit details
-
Copy full SHA for e94c730 - Browse repository at this point
Copy the full SHA e94c730View commit details -
Configuration menu - View commit details
-
Copy full SHA for 543d0d2 - Browse repository at this point
Copy the full SHA 543d0d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ca1189 - Browse repository at this point
Copy the full SHA 1ca1189View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79e1d54 - Browse repository at this point
Copy the full SHA 79e1d54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d62585 - Browse repository at this point
Copy the full SHA 5d62585View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcd5381 - Browse repository at this point
Copy the full SHA dcd5381View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb88a95 - Browse repository at this point
Copy the full SHA bb88a95View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.