feat: deploy command global config with function context #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
kind/enhancement
do-not-merge/work-in-progress
knative-prow-robot
added
the
needs-rebase
knative-prow
bot
added
the
size/XXL
lkingland
force-pushed
the
lkingland/deploy-global-config
branch
from
37fbe81
to
43b1167
Compare
knative-prow-robot
removed
the
needs-rebase
lkingland
changed the title
lkingland
changed the title
Codecov ReportBase: 54.40% // Head: 63.70% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1434 +/- ##
==========================================
+ Coverage 54.40% 63.70% +9.30%
==========================================
Files 72 75 +3
Lines 10685 10826 +141
==========================================
+ Hits 5813 6897 +1084
+ Misses 4441 3359 -1082
- Partials 431 570 +139
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lkingland
force-pushed
the
lkingland/deploy-global-config
branch
from
25e9620
to
c670d14
Compare
lkingland
force-pushed
the
lkingland/deploy-global-config
branch
from
c670d14
to
4b6b36c
Compare
knative-prow-robot
added
the
needs-rebase
lkingland
force-pushed
the
lkingland/deploy-global-config
branch
from
317aea9
to
a73b6ab
Compare
knative-prow-robot
added
needs-rebase
lkingland
force-pushed
the
lkingland/deploy-global-config
branch
from
0ee7e09
to
3f5f6cb
Compare
knative-prow-robot
removed
the
needs-rebase
lkingland
force-pushed
the
lkingland/deploy-global-config
branch
from
3f5f6cb
to
56c3a33
Compare
|
Probably fixes: #1492 |
knative-prow-robot
added
the
needs-rebase
lkingland
force-pushed
the
lkingland/deploy-global-config
branch
from
a686b3d
to
47260a8
Compare
knative-prow-robot
removed
the
needs-rebase
lkingland
force-pushed
the
lkingland/deploy-global-config
branch
6 times, most recently
from
41adee6
to
c5f2d46
Compare
knative-prow-robot
added
the
needs-rebase
|
@lkingland it seems that this needs rebase, but it is looking good |
- Built() now a client package function - Namespace evaluation delegeate to implementations This enables the func.yaml to avert dirtiness checks on rebuilds (caching) - Build and Deploy update build stamp on completion Enables dirtiness checks to be unaffects, leading to better caching. - CLI Namespace checks no longer require k8s env evaluation for default - Fixed missing condition check in TestDeploy_Namespace - Fixes some minor linter and spelling errors - Global config does not directly set namespace - it is corrected to be deferred evaluation used by implementations. - Skips writing func.yaml on f.Write if there were no modifications, which leads to better caching (no timestamp update means Built == true) - HasImage removed in favor of a corrected fn.Built
lkingland
force-pushed
the
lkingland/deploy-global-config
branch
from
dc7e0f7
to
bb88a95
Compare
knative-prow-robot
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, salaboy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lance
pushed a commit
to lance/func
that referenced
this pull request
Feb 15, 2023
* feat: deploy command global config function context * fix static check errors * fix test * fix remote persists test * env opaque box test * use keyed fields (govet) * mock deployer expansion * ClearEnvs now in shared testing pkg * effectivePath now uses plfags * list directly uses config for default namespace * Improved Namespace calculation and Caching - Built() now a client package function - Namespace evaluation delegeate to implementations This enables the func.yaml to avert dirtiness checks on rebuilds (caching) - Build and Deploy update build stamp on completion Enables dirtiness checks to be unaffects, leading to better caching. - CLI Namespace checks no longer require k8s env evaluation for default - Fixed missing condition check in TestDeploy_Namespace - Fixes some minor linter and spelling errors - Global config does not directly set namespace - it is corrected to be deferred evaluation used by implementations. - Skips writing func.yaml on f.Write if there were no modifications, which leads to better caching (no timestamp update means Built == true) - HasImage removed in favor of a corrected fn.Built * linting, misspellings and docs rebuild * warn user if git settings exist on a non-remote build * lint error fix * test flag unsetting persists * allow unknown flags in preparsing of flags * pre-submit cleanup * update cmd to use client.Init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #901
/kind enhancement
Release Note