-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deploy command global config with function context #1434
feat: deploy command global config with function context #1434
Conversation
37fbe81
to
43b1167
Compare
Codecov ReportBase: 54.40% // Head: 63.70% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1434 +/- ##
==========================================
+ Coverage 54.40% 63.70% +9.30%
==========================================
Files 72 75 +3
Lines 10685 10826 +141
==========================================
+ Hits 5813 6897 +1084
+ Misses 4441 3359 -1082
- Partials 431 570 +139
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
25e9620
to
c670d14
Compare
c670d14
to
4b6b36c
Compare
317aea9
to
a73b6ab
Compare
0ee7e09
to
3f5f6cb
Compare
3f5f6cb
to
56c3a33
Compare
Probably fixes: #1492 |
a686b3d
to
47260a8
Compare
41adee6
to
c5f2d46
Compare
@lkingland it seems that this needs rebase, but it is looking good |
- Built() now a client package function - Namespace evaluation delegeate to implementations This enables the func.yaml to avert dirtiness checks on rebuilds (caching) - Build and Deploy update build stamp on completion Enables dirtiness checks to be unaffects, leading to better caching. - CLI Namespace checks no longer require k8s env evaluation for default - Fixed missing condition check in TestDeploy_Namespace - Fixes some minor linter and spelling errors - Global config does not directly set namespace - it is corrected to be deferred evaluation used by implementations. - Skips writing func.yaml on f.Write if there were no modifications, which leads to better caching (no timestamp update means Built == true) - HasImage removed in favor of a corrected fn.Built
dc7e0f7
to
bb88a95
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, salaboy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* feat: deploy command global config function context * fix static check errors * fix test * fix remote persists test * env opaque box test * use keyed fields (govet) * mock deployer expansion * ClearEnvs now in shared testing pkg * effectivePath now uses plfags * list directly uses config for default namespace * Improved Namespace calculation and Caching - Built() now a client package function - Namespace evaluation delegeate to implementations This enables the func.yaml to avert dirtiness checks on rebuilds (caching) - Build and Deploy update build stamp on completion Enables dirtiness checks to be unaffects, leading to better caching. - CLI Namespace checks no longer require k8s env evaluation for default - Fixed missing condition check in TestDeploy_Namespace - Fixes some minor linter and spelling errors - Global config does not directly set namespace - it is corrected to be deferred evaluation used by implementations. - Skips writing func.yaml on f.Write if there were no modifications, which leads to better caching (no timestamp update means Built == true) - HasImage removed in favor of a corrected fn.Built * linting, misspellings and docs rebuild * warn user if git settings exist on a non-remote build * lint error fix * test flag unsetting persists * allow unknown flags in preparsing of flags * pre-submit cleanup * update cmd to use client.Init
Related: #901
/kind enhancement
Release Note