[RHDM-2029] Executable model doesn't report an error when duplicated #59
Conversation
…rule name with "include" kbase
…KieBaseIncludeTest
| super.validateUniqueRuleNames(packageDescr); | ||
|
|
||
| // check for duplicated rule names in included kbase | ||
| List<String> ruleNames = includedRuleNameMap.computeIfAbsent(packageDescr.getNamespace(), k -> new ArrayList<>()); |
There was a problem hiding this comment.
Is this computeIfAbsent necessary? I believe you could simply skip the subsequent for-loop and any other check if the map doesn't contain an entry with the given package name.
| @@ -68,6 +84,8 @@ public class ModelBuilderImpl<T extends PackageSources> extends KnowledgeBuilder | |||
|
|
|||
| private Map<String, CompositePackageDescr> compositePackagesMap; | |||
|
|
|||
| private Map<String, List<String>> includedRuleNameMap = new HashMap<>(); | |||
There was a problem hiding this comment.
Nitpick: it would be a bit better to replace the List with a Set for the values of this Map. In this way the contains performed here would use the String hashing instead of doing a linear search.
| CanonicalKieModule canonicalKieModule = (CanonicalKieModule) includeModule; | ||
| Collection<Model> includeModels = canonicalKieModule.getModelForKBase((KieBaseModelImpl)kieBaseModel); | ||
| for (Model includeModel : includeModels) { | ||
| includeModel.getRules().forEach(rule -> includedRuleNameMap.computeIfAbsent(includeModel.getPackageName(), k -> new HashSet<>()).add(rule.getName())); | ||
| } |
There was a problem hiding this comment.
Using getModelForKBase instead of getKiePackage. Hopefully, less overhead.
|
@mariofusco I raised another variant #60 which checks duplication at createKieBase time, rather than kbuilder build time. I think this (#59) PR is better. WDYT? |
Yes, I agree. I will approve and merge this PR and close the other. |
This PR is a variant of #58 using
canonicalKieModule.getKiePackages()rather thangetKieBase()Ports
This PR is for 7.x
7.67.x ->
JIRA:
https://issues.redhat.com/browse/RHDM-2029
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests
for a full downstream build
run_fdba compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native
for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts
for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.