[incubator-kie-drools-6007] Executable model doesn't report an error … #6013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when duplicated * removing kie-ci from dependency, because it causes a test failure in KieBaseIncludeTest * Use canonicalKieModule.getKiePackages() rather than getKieBase() * null check for kiePackage * move populateIncludedRuleNameMap out of packages loop * removed unused FileManager * performance improvement. Use getModelForKBase instead of getKiePackages * Fit into build phases * clean up
|
This is a forward port PR of kiegroup#59 and kiegroup#61 from 7.x. The main branch was refactored to use |
|
@mariofusco @lucamolteni @pibizza Please review, thanks! |
mariofusco
approved these changes
Jul 9, 2024
lucamolteni
approved these changes
Jul 9, 2024
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Jul 17, 2024
…when duplicated (apache#6013) * removing kie-ci from dependency, because it causes a test failure in KieBaseIncludeTest * Use canonicalKieModule.getKiePackages() rather than getKieBase() * null check for kiePackage * move populateIncludedRuleNameMap out of packages loop * removed unused FileManager * performance improvement. Use getModelForKBase instead of getKiePackages * Fit into build phases * clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when duplicated
removing kie-ci from dependency, because it causes a test failure in KieBaseIncludeTest
Use canonicalKieModule.getKiePackages() rather than getKieBase()
null check for kiePackage
move populateIncludedRuleNameMap out of packages loop
removed unused FileManager
performance improvement. Use getModelForKBase instead of getKiePackages
Fit into build phases
clean up
Issue: