Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dropout support in ConvLSTMCell. #20089

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

hertschuh
Copy link
Contributor

Implemented dropout and recurrent dropout in ConvLSTMCell with the same approach as in Keras 2.

Fixes #20063

Implemented dropout and recurrent dropout in `ConvLSTMCell` with the same approach as in Keras 2.

Fixes keras-team#20063
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.29%. Comparing base (445da52) to head (8c7ef30).

Files Patch % Lines
keras/src/layers/rnn/conv_lstm.py 71.42% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20089      +/-   ##
==========================================
- Coverage   79.30%   79.29%   -0.01%     
==========================================
  Files         501      501              
  Lines       46966    46983      +17     
  Branches     8655     8659       +4     
==========================================
+ Hits        37246    37257      +11     
- Misses       7971     7976       +5     
- Partials     1749     1750       +1     
Flag Coverage Δ
keras 79.15% <79.31%> (-0.01%) ⬇️
keras-jax 62.48% <79.31%> (+<0.01%) ⬆️
keras-numpy 57.50% <34.48%> (-0.02%) ⬇️
keras-tensorflow 63.83% <79.31%> (+<0.01%) ⬆️
keras-torch 62.52% <79.31%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you for the fix.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Aug 6, 2024
@fchollet fchollet merged commit 473a8ec into keras-team:master Aug 6, 2024
8 of 10 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropout in ConvLSTM Cell
5 participants