Dropout in ConvLSTM Cell

[dryglicki]

Really quick question here.

In the ConvLSTMCell here, the dropout code has been commented out. recurrent_dropout also doesn't seem to do anything, except it is used in the DropoutRNNCell mixin.

Is this a bug or am I missing something?

[sachinprasadhs]

This code snippet was commented in the fix here 2cae421 to fix Conv LSTM correctness

[dryglicki]

Hi @sachinprasadhs, can you be a little more clear with this explanation? What does "correctness" mean here, exactly?

I've been looking at the base RNN layer here: https://github.com/keras-team/keras/blob/master/keras/src/layers/rnn/rnn.py. Is the dropout now done under the hood?

In the Dropout Test here (https://github.com/keras-team/keras/blob/master/keras/src/layers/rnn/dropout_rnn_cell_test.py), those two calls aren't commented out.

[google-ml-butler]

Are you satisfied with the resolution of your issue?
Yes
No

[google-ml-butler]

Are you satisfied with the resolution of your issue?
Yes
No

[hertschuh]

@dryglicki ,

Thank you for the report. This was an oversight. It is now fixed.