-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create command for updating auto-generated docs and helm resources for CRD structs #2897
Conversation
Signed-off-by: Griffin <prakritimandal611@gmail.com>
|
Hey @prakrit55 great job here! To simplify your scripts a bit you may want to have a look to Kustomize transformers and patches: basically, there is a way to define how your yaml file should be enriched when you run the make generate command for instance to add labels like you do in your script :) some maybe helpful links: https://medium.com/@giorgiodevops/kustomize-use-patches-to-add-or-override-resources-48ef65cb634c |
Thanks @RealAnna, this so cool with kustomize for the |
If you manage to add the helm templates bits in the CRD as a separate patch this means you can directly call kustomize in the chart/templates folder and substitute the files there. So a variation of what we have here but instead of using | you store the resource in a file in the chart path ... I have not tested wheter everything can be done like this, but you could choose one crd file and test this out :) |
Hi @prakrit55 any news on this PR? |
was a bit busy, will start working on it : ) |
hello @odubajDT, had a query with |
Hi @prakrit55 not sure I understand your question. But I don't think producing a single file output is the goal. What I think Anna suggested is to actually template the CRDs and create it basically "substituable", but in multiple templates files. Can you explain your thoughts a little bit more ? |
Sorry for the confusion. So I tried to run |
@prakrit55 I think having all crd in a file is an acceptable outcome as long as we are certain that the content is automatically updated 😃 |
|
Fixes #1879
Description
How to test
Please describe how to run the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also provide information about any automatic tests that you added.
Checklist
into multiple PRs)
see Contribution Guide
the Contribution Guide
Summary
Please include a short summary of the changes and the related issue.
Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Checks
into multiple PRs)
see Contribution Guide)
the Contribution Guide
from the Netlify deploy preview