chore: create command for updating auto-generated docs and helm resources for CRD #3137
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3137 +/- ##
==========================================
+ Coverage 85.75% 86.77% +1.02%
==========================================
Files 162 162
Lines 10351 8590 -1761
==========================================
- Hits 8876 7454 -1422
+ Misses 1186 844 -342
- Partials 289 292 +3 see 139 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@RealAnna, could you check it once |
| @@ -0,0 +1,13 @@ | |||
| #!/bin/bash | |||
|
|
|||
There was a problem hiding this comment.
instead of adding a new script in .github I will add them in the respective operators MAKEFILEs
There was a problem hiding this comment.
if possible I would prefer AWK instead of sed since some features of sed are not standardized across platforms
|
@RealAnna, could u check it once again, made the changes |
|
@prakrit55 sorry for the late review, can you please resolve conflicts first so we can run pipeline tests? |
prakrit55
force-pushed
the
chore/command-to-autogenerateHelmandDocs
branch
from
223bfd8
to
2c3f0b7
Compare
|
Description
Fixes #1879
How to test
Please describe how to run the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also provide information about any automatic tests that you added.
Checklist
into multiple PRs)
see Contribution Guide
the Contribution Guide
Summary
Please include a short summary of the changes and the related issue.
Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Checks
into multiple PRs)
see Contribution Guide)
the Contribution Guide
from the Netlify deploy preview