Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove country-regex and replace it with a more modern version #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

keithrob
Copy link
Owner

@keithrob keithrob commented Jun 8, 2019

The NPM package that is currently used by plotly, country-regex, is a very good package for taking common country names and correlating them to their ISO3 codes. However, it used a GPLed regex library from the R package countrycode. It is questionable whether country-regex can be a MIT license when it is a direct descendent of R version.

This PR has selected i18n-iso-countries as a replacement for country-regex. Admittedly, it cannot perform the same level of common name matching that country-regex could; therefore, there is some degree of feature loss. However, this package does seem to be updated more frequently and tracks the standards more closely.

@etpinard

@etpinard
Copy link

You're right country-regex should have had a GPLv3 license from the start. Thanks for spotting that and sorry for my mistake.

Will it be ok to just change the license over in the country-regex package?

@etpinard
Copy link

Moreover, I'm curious. Why are you stating that i18n-iso-countries is more modern than country-regex? Is country-regex missing a few entries?

@keithrob
Copy link
Owner Author

@etpinard,
Re: "Will it be ok to just change the license over in the country-regex package?"

  • That would certainly align country-regex with its origin R package and should be done. However, it would also have transitive implications for plotly.js. I am not a lawyer but I am fairly certain that this would mean that Plotly.js would need to carry the GPL license. If this were to happen commercial organizations would likely avoid using Plotly.js.

Re: "Why are you stating that i18n-iso-countries is more modern than country-regex? Is country-regex missing a few entries?"

  • Looks like country-regex uses country.js which hasn't been updated in 8years. I haven't done an extensive audit but the ISO page says their dictionary "regularly updated".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants