Remove country-regex and replace it with a more modern version #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NPM package that is currently used by plotly, country-regex, is a very good package for taking common country names and correlating them to their ISO3 codes. However, it used a GPLed regex library from the R package countrycode. It is questionable whether country-regex can be a MIT license when it is a direct descendent of R version.
This PR has selected i18n-iso-countries as a replacement for country-regex. Admittedly, it cannot perform the same level of common name matching that country-regex could; therefore, there is some degree of feature loss. However, this package does seem to be updated more frequently and tracks the standards more closely.
@etpinard