Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace country-regex #3944

Closed
keithrob opened this issue Jun 8, 2019 · 3 comments
Closed

Replace country-regex #3944

keithrob opened this issue Jun 8, 2019 · 3 comments

Comments

@keithrob
Copy link

keithrob commented Jun 8, 2019

I have created a PR[1] to replace country-regex due to some licensing issues. Motivation for the change is detailed in the PR itself.

[1] keithrob#1

@etpinard , @archmoj FYI

@keithrob
Copy link
Author

@etpinard ,
Any update on whether or not country-regex can be removed? Another option might be to make it a pluggable/optional component that isn't included with the base package.

@G-2-Z
Copy link

G-2-Z commented May 28, 2020

Is there any update on this? Its been almost a year now and this little dependency is a big hurdle for anything not open source wanting to use plotly, if they stumble uppon it (country-regex itself is still MIT).

@gvwilson
Copy link
Contributor

Hi - we are currently trying to tidy up Plotly's public repositories to help us focus our efforts on things that will help users most. Since this issue has been sitting for several years, I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our backlog. Thanks for your help - @gvwilson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants