New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honk verifier implementation #119

Merged

feltroidprime merged 41 commits into keep-starknet-strange:main from raugfer:feat/honk-verifier

Apr 18, 2024

Collaborator

raugfer commented Apr 15, 2024 •

edited

Loading

This PR adds src/precompiled_circuits/honk.py a Python port of the Solidity Honk proof verifier provided by https://github.com/Maddiaa0/honk-verifier/

Pull Request type

Feature

What is the current behavior?

An extension/feature was added, the current behavior lacks this new functionality.

Issue Number: #62

What is the new behavior?

Adds src/precompiled_circuits/honk.py that exports verify function to verify Honk proofs
Adds two proof verification tests under src/precompiled_circuits/honk_tests folder
Extends the GnarkCLI with point addition and scalar multiplication
Adds g1 and ng1 commands as extensions to the Gnark golang implementation

Does this introduce a breaking change?

No

raugfer added 17 commits

April 8, 2024 19:18


          Adds fist pass of translation from Solidity

92ce5a0


          Adds Transcript implementation

ffb3fc1


          Add code translation from utils.sol

36a28d0


          Partial commit of verifier half way through translation

256ff79


          Finishes Solidity => Python translation, except for BN256 functions

4976bb9


          Adds dump functions to aid in debugging

e1b040c


          Fixes proof parsing and adds a function to dump a Transcript object

fde09bb


          Fixes translation bug in scaleAndBatchSubrelations

e21010e


          Fixes the bug that was preventing verifyZeroMorph() from succeeding

76a9c2b


          Comment out debugging code

1dddae0


          Adds BN256 test code as comments

eebc0e5


          Replaces Fr by PyFelt type

33ce4d6


          Implements bn256_add and bn256_mul, reorganizes the code a bit

e6a11af


          Adds bn256 add/scalarmul implementation via Gnark CLI

4ca5ee0


          Implements the BN256 pairing check using the Gnark CLI

0b0eaa3


          Comments out the Python implementation of BN256 add/scalarmul on its …

64306f4

…own block


          Improves comment block for ease of type checking

1c50069

raugfer changed the title ~~Honk verifier impplementation~~ Honk verifier implementation

feltroidprime reviewed

View reviewed changes

src/precompiled_circuits/honk.py Outdated Show resolved Hide resolved

feltroidprime reviewed

View reviewed changes

src/precompiled_circuits/honk.py Outdated Show resolved Hide resolved

feltroidprime reviewed

View reviewed changes

src/precompiled_circuits/honk.py Outdated Show resolved Hide resolved

feltroidprime reviewed

View reviewed changes

src/precompiled_circuits/honk.py Outdated Show resolved Hide resolved

feltroidprime reviewed

View reviewed changes

src/precompiled_circuits/honk.py Show resolved Hide resolved

feltroidprime reviewed

View reviewed changes

src/precompiled_circuits/honk.py Outdated Show resolved Hide resolved

raugfer added 6 commits

April 16, 2024 10:00


          Imports BN256 field/group order constants from definitions.py

29f0112


          Adds comments to bytes <-> int <-> hex str conversion functions

f5099b9


          Adds comments to abi_encodePacked function

16f6c28


          Updates bn256_pairing to use cli.pair

5d6b95a


          Refactors the BN256 add/scalarmul/pairing, moving operations into the…

769fb67

… GnarkCLI class


          Replaces Fr(value=...) by Fr(...)

392fc6c

raugfer added 18 commits

April 16, 2024 12:43


          Generalizes bn256_pairing to support an arbitrary number of pairs

ddab02a


          Adds @DataClass slot and frozen attributes, refactors ecSub/ecNeg fun…

c25163e

…ctions


          Adds slots=True to @DataClass annotations

af43203


          Replaces Fr(c) by c wherever possible

a2fd214


          Refactors batchMul/batchMul2

14faa45


          Move Honk verifier test files into their own folder


          Applies checkSum() function call fix

0927e08


          Replaces keccak256 custom implementation by the one supplied by eth_hash


          Removes unused function

cc69f5f


          Cleans up value conversion code

a819832


          Removes trailing space

a206c6c


          Replaces eth_hash by web3 to import the keccak256 implementation

a2eeec5


          Cleans up ecSub implementation

58c8c41


          Refactors ABI encoding function and related code

361ff81


          Refactor of Fr functions

f9dcfc6


          Removes obsolete comments

59bc358


          Replaces hardcoded 44 by NUMBER_OF_ENTITIES + 1

298fae0


          Removes comment blocks with typing help declarations and alternative …

a3090fd

…EC operations

raugfer marked this pull request as ready for review

April 18, 2024 14:31

feltroidprime merged commit 0e42102 into keep-starknet-strange:main

1 check passed

raugfer deleted the feat/honk-verifier branch

April 18, 2024 20:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet