Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Verify Noir circuits #62

Closed
feltroidprime opened this issue Apr 5, 2023 · 1 comment
Closed

feat: Verify Noir circuits #62

feltroidprime opened this issue Apr 5, 2023 · 1 comment
Assignees
Labels
enhancement Enhancement of the code, not introducing new features.

Comments

@feltroidprime
Copy link
Collaborator

feltroidprime commented Apr 5, 2023

Write a verifier in python for Honk proofs based on this repo : https://github.com/Maddiaa0/honk-verifier/tree/master

how to :
- use garaga's python classes : [PyFelt](https://github.com/keep-starknet-strange/garaga/blob/ 07ad865/src/algebra.py#L5) for modular arithmetic operations.
- use / add (if needed) Elliptic curves information and constants from definitions.py
- write the verifier in a single python file under src/precompiled_circuits/honk.py.
- Do not write a ModuloCircuit class (this will be done later), only the verifier inside a function.
- You can copy paste and re-use the code here for EC scalar multiplication https://github.com/feltroidprime/zk-ecip-py/blob/main/src/curve.py when the solidity is using the ECMul/EcADD precompile
- You can use the gnark CLI backend when the solidity is using the EcPairing precompile
- add some python functions to parse and map the honk proof into a proper python dataclass inside honk.py
- write a similar test than in the honk-verifier repo inside the if __name__ == "__main__": part of the honk.py file.
- write clear code with type hints

Done.

Next task : Write a cairo implementation.
Requires #112

@feltroidprime feltroidprime added the enhancement Enhancement of the code, not introducing new features. label Apr 5, 2023
@feltroidprime feltroidprime self-assigned this Apr 13, 2023
@github-actions github-actions bot added the stale No activity for quite some time. label May 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2023
@feltroidprime feltroidprime removed the stale No activity for quite some time. label Oct 2, 2023
@feltroidprime feltroidprime reopened this Nov 9, 2023
@feltroidprime
Copy link
Collaborator Author

feltroidprime commented Apr 4, 2024

Looking for a contributor

@feltroidprime feltroidprime removed their assignment Apr 4, 2024
@keep-starknet-strange keep-starknet-strange deleted a comment from github-actions bot Apr 4, 2024
@keep-starknet-strange keep-starknet-strange unlocked this conversation Apr 4, 2024
@keep-starknet-strange keep-starknet-strange deleted a comment from raugfer Apr 4, 2024
@feltroidprime feltroidprime self-assigned this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

No branches or pull requests

2 participants