Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug on kedro viz --load-file #1677

Merged
merged 8 commits into from
Dec 15, 2023
Merged

Fix bug on kedro viz --load-file #1677

merged 8 commits into from
Dec 15, 2023

Conversation

rashidakanchwala
Copy link
Contributor

@rashidakanchwala rashidakanchwala commented Dec 11, 2023

Description

Resolves #1676

Development notes

  • Updated docs to reflect changes on how we save kedro viz data
  • --save-file option with kedro viz run saves api data in the specified file_name/api. The api folder includes main, nodes/ , pipelines/
  • --load-file option with 'kedro viz run` loads kedro viz project data from file_name/api

QA notes

  • cd demo-project
  • Save api data using kedro viz run --save-file=testProject
  • Load api data using kedro viz run --load-file=testProject

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

rashidakanchwala and others added 5 commits December 11, 2023 13:48
Signed-off-by: Rashida Kanchwala <rashida.kanchwala@quantumblack.com>
Signed-off-by: Rashida Kanchwala <rashida.kanchwala@quantumblack.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review December 11, 2023 18:38
@ravi-kumar-pilla ravi-kumar-pilla requested review from ravi-kumar-pilla and jitu5 and removed request for tynandebold and yetudada December 11, 2023 18:39
@rashidakanchwala
Copy link
Contributor Author

LGTM. Can you approve Ravi!

@rashidakanchwala rashidakanchwala merged commit f483b30 into main Dec 15, 2023
17 checks passed
@rashidakanchwala rashidakanchwala deleted the fix/load-save-file branch December 15, 2023 13:12
@ravi-kumar-pilla ravi-kumar-pilla mentioned this pull request Dec 15, 2023
1 task
This was referenced Dec 18, 2023
rashidakanchwala added a commit that referenced this pull request Dec 19, 2023
Release 7.0.0

Major features and improvements

Upgrade to React 18. (Migrate to React 18 #1652)
Change CLI command to run Kedro-viz tokedro viz run. (Change 'Kedro Viz' to 'Kedro Viz Run' #1671)
Add deploy command to the CLI using kedro viz deploy for sharing Kedro-viz on AWS. (AWS focussed CLI implementation for Shareable Viz  #1661)
Add support for kedro==0.19and kedro-datasets==2.0. (Fix bug on kedro viz --load-file #1677)
Drop support for python=3.7. (Remove support for Python 3.7 #1660)
Drop support for kedro==0.17.x. (Drop Kedro 17  #1669)
Bug fixes and other changes
Fix modular pipelines breaking when collapsed on the flowchart. (Fix modular pipelines breaking when collapsed.  #1651)
Display hosted URL in CLI while launching Kedro viz. (Display hosted URL in CLI while launching kedro viz #1644)
Fix Kedro-viz display on Jupyter notebooks. (Fix Kedro-viz embedded as an IFrame #1658)
Fix zoom issues on the flowchart. (Flowchart doesn't automatically reset the zoom when actions are performed. #1672)
Fix bug on kedro-viz run --load-file. (Fix bug on kedro viz --load-file #1677)
Fix bug on adding timestamps to shareable-viz. (_#1679)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Save and Load Kedro Viz from a file broken
3 participants