Fix Kedro-viz embedded as an IFrame #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashidakanchwala
requested review from
ravi-kumar-pilla and
jitu5
and removed request for
tynandebold
ravi-kumar-pilla
approved these changes
Dec 4, 2023
rashidakanchwala
added a commit
that referenced
this pull request
Dec 19, 2023
Release 7.0.0 Major features and improvements Upgrade to React 18. (Migrate to React 18 #1652) Change CLI command to run Kedro-viz tokedro viz run. (Change 'Kedro Viz' to 'Kedro Viz Run' #1671) Add deploy command to the CLI using kedro viz deploy for sharing Kedro-viz on AWS. (AWS focussed CLI implementation for Shareable Viz #1661) Add support for kedro==0.19and kedro-datasets==2.0. (Fix bug on kedro viz --load-file #1677) Drop support for python=3.7. (Remove support for Python 3.7 #1660) Drop support for kedro==0.17.x. (Drop Kedro 17 #1669) Bug fixes and other changes Fix modular pipelines breaking when collapsed on the flowchart. (Fix modular pipelines breaking when collapsed. #1651) Display hosted URL in CLI while launching Kedro viz. (Display hosted URL in CLI while launching kedro viz #1644) Fix Kedro-viz display on Jupyter notebooks. (Fix Kedro-viz embedded as an IFrame #1658) Fix zoom issues on the flowchart. (Flowchart doesn't automatically reset the zoom when actions are performed. #1672) Fix bug on kedro-viz run --load-file. (Fix bug on kedro viz --load-file #1677) Fix bug on adding timestamps to shareable-viz. (_#1679)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In response to issue #1348, which required the addition of security headers to demo.kedro.org, we implemented a solution in PR #1355. This solution involved adding security headers to the FastAPI application which results in all instances of kedro-viz, whether hosted or local, having these security headers. Having the security headers introduced a limitation where kedro-viz could not be used as an IFrame, affecting functionalities like %run_viz that embed kedro-viz in an iframe.
To address this, the current ticket introduces a conditional approach. We will add security headers only if the environment variable ADD_SECURITY_HEADER is set to true. This modification will be implemented in the Dockerfile when creating the docker image for the demo project. This image will then be uploaded to an EC2 instance and deployed using Lightsail.
QA notes
I've conducted local tests and confirmed that security headers are no longer being added. Additionally, I tested this by creating a Docker image of the demo-project. In this scenario, the security headers are present and functioning as expected.
Checklist
RELEASE.mdfile