Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Prepare for Notebook v7 #323

Closed
wants to merge 26 commits into from
Closed

Prepare for Notebook v7 #323

wants to merge 26 commits into from

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 19, 2022

Opening this draft PR here for visibility, and to use the CI checks to make sure the renaming and other changes are correct. Also because retrolab / notebook 7 still lives in this current repo for now.

Initial steps towards JEP 79: https://jupyter.org/enhancement-proposals/79-notebook-v7/notebook-v7.html

This might be rebased once #319 lands.

Changes

@jtpio jtpio added the enhancement New feature or request label Jan 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2022

Binder 👈 Launch a Binder on branch jtpio/retrolab/notebook-repo

@jtpio
Copy link
Member Author

jtpio commented Jan 19, 2022

Since jupyterlab still depends on nbclassic at the moment we are getting the following error:

ImportError: cannot import name 'DEFAULT_STATIC_FILES_PATH' from 'notebook' (/home/runner/work/retrolab/retrolab/notebook/__init__.py)

From https://github.com/jupyterlab/retrolab/runs/4867923562?check_suite_focus=true

@Zsailer
Copy link
Member

Zsailer commented Feb 10, 2022

Let's add notebook_shim to this PR to replace nbclassic.

@jtpio
Copy link
Member Author

jtpio commented Feb 10, 2022

Let's add notebook_shim to this PR to replace nbclassic.

Done in 2435634

@jtpio
Copy link
Member Author

jtpio commented Feb 11, 2022

Next step will be to get jupyterlab/jupyterlab#11894 merged in JupyterLab, and released in 4.0.0ax so it can be consumed here in this PR.

name = "retro"
app_name = "RetroLab"
description = "RetroLab - A JupyterLab Distribution with a retro look and feel"
class JupyterNotebookApp(NotebookConfigShimMixin, LabServerApp):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class needs to be named something else than NotebookApp.

Otherwise the traits translation provided by notebook_shim would try to convert for example NotebookApp.collaborative to ServerApp.collaborative, but collaborative does not exist on ServerAppbut onLabApp`.

$ jupyter notebook --no-browser
[C 2022-02-25 10:12:36.754 LabApp] Bad config encountered during initialization: Trait, expose_app_in_browser, not found.

cc @Zsailer to double check this is fine, which I believe it should, since JupyterNotebookApp inherits from ServerApp.

@jtpio
Copy link
Member Author

jtpio commented Feb 25, 2022

This can be tested on Binder: https://mybinder.org/v2/gh/jtpio/retrolab/notebook-repo?urlpath=tree

The jupyter notebook command (default of `repo2docker) will now launch a Jupyter Server, and not the Classic Notebook Server anymore.

notebook-binder.mp4

@jtpio
Copy link
Member Author

jtpio commented Feb 25, 2022

cc @Zsailer if you would like to do a first round of review (or anyone else interested).

Some UI tests are still a bit flaky (#341).

I'm also planning to finish #352 first, and integrate the changes here.

Then this branch (https://github.com/jtpio/retrolab/tree/notebook-repo) should be ready to be integrated in https://github.com/jupyter/notebook. There will still be some things to fix like the merge with existing files (readme, changelog...) but we can iterate there then. Hoping to open the PR in https://github.com/jupyter/notebook/ some time next week.

@jtpio
Copy link
Member Author

jtpio commented Mar 2, 2022

Closing since the corresponding PR has been opened on the notebook repo: jupyter/notebook#6294

@jtpio jtpio closed this Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants