Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook v7 scaffolding #6294

Merged
merged 670 commits into from
Mar 7, 2022
Merged

Notebook v7 scaffolding #6294

merged 670 commits into from
Mar 7, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 1, 2022

Closes #6293

Fixes jupyter/notebook-team-compass#6

See #6266 for more context about the 7.0 pre-release plan.

This is the initial step towards implementing the Notebook v7 JEP: https://jupyter.org/enhancement-proposals/79-notebook-v7/notebook-v7.html

This PR incorporates the RetroLab code base, which currently lives in https://github.com/jupyterlab/retrolab.
More specifically, it is based on the following PR which served as a preparation for the move: jupyterlab/retrolab#323

Fixes jupyterlab/retrolab#313

Try it on Binder

Binder

image

TODO

  • Bump version to 7.0.0a0
  • Update README.md with relevant information about the different stream of works (classic notebook v6 and notebook v7)
  • Update issue templates (Update issue templates for the jupyter/notebook repo notebook-team-compass#7)
  • Fix docs build
  • Update or remove the example notebook on Binder
  • Cleanup files that are not needed anymore (previous CI workflows, templates...)

jtpio and others added 30 commits September 22, 2021 19:41
Add a Binder section to the readme
…11ec91908b1e004b2ee0

Automated Changelog Entry for 0.3.7 on main
…11ecb11a9da391706d9c

Automated Changelog Entry for 0.3.7 on main
SHA256 hashes:

retrolab-0.3.7-py3-none-any.whl: 706c2ce0195e6d694539bb5a32d2273fd0a43e5caace7bcc1fe5de1fdec226fa

retrolab-0.3.7.tar.gz: 790b7ea9d3d211659633120e47373c594527b16961090cc8ac1941a4efa0b6fb

retrolab-application-0.3.7.tgz: 7a2590514d457e33335778365907d54bceab451d42a6fd28aeb4396f74026dd5

retrolab-application-extension-0.3.7.tgz: 65713f96aa7a775f3b8921bf88613696f6a4735e10fbd6689d5ce7db9bd3876d

retrolab-console-extension-0.3.7.tgz: 98451eeb6e4de367e98128e41f6e51bfbb33774154824fa5a0b509b0ef27ffa4

retrolab-docmanager-extension-0.3.7.tgz: f968133104d15bff991ab08d4c4988d35f29a60a2b11814fad227ad70a3cc6c9

retrolab-help-extension-0.3.7.tgz: 7188590fd0739eb949390bdfcf00a58f50ada042eaca93aa27a8191a061a8466

retrolab-lab-extension-0.3.7.tgz: a79f656cfa6df0609fd6897ad881e6f88f78eb2c8589da2ccf10c5064e254fe9

retrolab-notebook-extension-0.3.7.tgz: 752d79106f459ab93c75fe6c81111a4c6e5cca6ee0ccd6469f4fc8637f9496e3

retrolab-terminal-extension-0.3.7.tgz: 2bb4a826e08c50c27a83bf2d8dc2643f1e2c92e541324ed0d3b79de251da6b8c

retrolab-tree-extension-0.3.7.tgz: 82eccdac05b493772441da9f9254069902a68d2a3ae1908a23279f464e9ee7fd

retrolab-ui-components-0.3.7.tgz: 83c1ba8ebb9c59acc2530e6a08e6c31c5747443cad3055e4e1bb855908086174
Update link to the stable Binder
Add missing translations to help extension
Improve tree page tab bar CSS
Support disabling core retrolab extensions
More document-oriented feel for the notebook (scrollbar)
…11ec95a6cba35430c847

Automated Changelog Entry for 0.3.8 on main
SHA256 hashes:

retrolab-0.3.8-py3-none-any.whl: 76cee722f2e455ba06b8629ace5675ff1488f5c2979aef007a03c8a1722cffcc

retrolab-0.3.8.tar.gz: 3dc7150d3db6b51a8887143dd697c7cf5f95a70323821f6b019673f1ddd07101

retrolab-application-0.3.8.tgz: 420360584d7d6f9729ae50bc0e244ffe767dbd064d1896abf511bad55b961069

retrolab-application-extension-0.3.8.tgz: 2ec4abc48c2e319f881fc01870933cd74fddc91bd88c8e85b4c072bfb7190be9

retrolab-console-extension-0.3.8.tgz: b870addcfef46ed0cbfacf5a9cdb03f2a5fe20712debb85c89931a816604feba

retrolab-docmanager-extension-0.3.8.tgz: 6a9ffa01d64a39d010b345b2952136032a895d876ddfecc6aa0f80f8229f767d

retrolab-help-extension-0.3.8.tgz: 04968dc9662b0aac83853ad367ea56b3d221546f4436a1b0138558d4976bad87

retrolab-lab-extension-0.3.8.tgz: 96dc7dcc4dfb96dccf66db62be3bf2bb4968f97c1756059a440bcd1f9eb810c7

retrolab-notebook-extension-0.3.8.tgz: 8ca8efc5d3c81ccb687772063b635a41a9603fd3cad3b6597e4823c74ed39f29

retrolab-terminal-extension-0.3.8.tgz: 03e27a9299af9c0f3a715df4452008c2a752de0953d75f051da875e410d8d312

retrolab-tree-extension-0.3.8.tgz: 56d72a9a1ba36fedbe5b2c03d59d2f9e107880be7a8a5ea18e1f4fb44a413920

retrolab-ui-components-0.3.8.tgz: 0e593dbe249ebe132da1aca82c09626df87d63deb893f515cf8d46a0060d8716
@jtpio
Copy link
Member Author

jtpio commented Mar 4, 2022

Pushed some cleanup to the docs to:

  • Update to the PyData Sphinx Theme so it's consistent with the other Jupyter projects
  • Remove outdated docs about v6 frontend extensions
  • Link to the Jupyter Server for server related config and security

The documentation preview for this PR is available on ReadTheDocs: https://jupyter-notebook--6294.org.readthedocs.build/en/6294/

@jtpio
Copy link
Member Author

jtpio commented Mar 4, 2022

The docs and README can still be iterated on, but should be "good enough" for now.

The missing item for this PR would be to update the issue templates to properly orient users and not confuse them.
Although this could also be postponed until we have the first 7.0 pre-release out. Since the new Notebook v7 is not installable for now anyway.

cc @Zsailer @afshin @jweill-aws if you have any input / ideas on this, since this is something that was discussed at the notebook and triage meetings


});
- `JupyterLab Extension Tutorial <https://jupyterlab.readthedocs.io/en/latest/extension/extension_tutorial.html>`_: A tutorial to learn how to make a simple JupyterLab extension.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to make a proper extension tutorial for 7.0, specific to the Notebook interface.

For example to add a button to the notebook toolbar.

@jtpio jtpio marked this pull request as ready for review March 4, 2022 17:01
@jtpio
Copy link
Member Author

jtpio commented Mar 4, 2022

Marking as ready for review so folks can already have a look and try it on Binder:

https://mybinder.org/v2/gh/jtpio/notebook/notebook-7?urlpath=tree

@Zsailer
Copy link
Member

Zsailer commented Mar 6, 2022

AMAZING work here, @jtpio! I've checked out this PR locally and confirm everything is working beautifully.

As for a thorough code review, it's nearly impossible with 627 files! 😅

Here's what I propose... let's merge and iterate. This looks good to go from my perspective. We can address issues as they arise and move faster after this update.

Thank you for all of this hard work, Jeremy—this can't be said enough! You deserve all the credit here! 🎉

(I'll merge Monday if you don't have any issues with this @jtpio).

@jasongrout
Copy link
Member

+28,194 −90,947

Wow. Just wow. Hats off to you!

@jtpio
Copy link
Member Author

jtpio commented Mar 6, 2022

(I'll merge Monday if you don't have any issues with this @jtpio).

Sounds good to me, let's wait until Monday and I'll let you merge @Zsailer. Thanks!

@Zsailer
Copy link
Member

Zsailer commented Mar 7, 2022

Alright, folks! Here we go!

Merging away. 🚀

@choldgraf
Copy link
Contributor

YayYesGIF

@jtpio jtpio deleted the notebook-7 branch March 8, 2022 14:00
@fperez
Copy link
Member

fperez commented Mar 8, 2022

Wohooo!!! Hats off @jtpio for this incredible work, thank you so much. Next time we catch up, 🍺/🍷/☕ on me! The entire project is going to benefit immensely from resolving this choke point, and this sets up a great path forward.

Also big thank you to @Zsailer, the rest of the team, and all the users who patiently have given input and feedback. Still a lot of work ahead to ensure that we have no regressions in the user experience, but this is where we wanted to be now! Exciting times ahead.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the jupyter/notebook repo default branch to main Update npm packages to the @jupyter-notebook scope