-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep version of magics package consistent in future releases #745
base: main
Are you sure you want to change the base?
Conversation
7b96698
to
fc264bd
Compare
It looks like #732 is causing a failure in the workflow. Looking into it now. |
c8137f9
to
93e376b
Compare
93e376b
to
a3e3c0b
Compare
315fdab
to
460c3cf
Compare
460c3cf
to
a400240
Compare
Unfortunately there doesn't seem to be a way to do this with Jupyter Releaser, due to the
When we bump to a new version in Jupyter Releaser, say I am currently evaluating other possibilities for preventing #730 in the future. One option is to vendor |
Just FYI I went through many of the same issues when refactoring https://github.com/jupyterlab/jupyter-collaboration into a monorepo. You might find something useful in jupyterlab/jupyter-collaboration#280, but some are yet to be solved. I think we can make jupyter-releaser work with it with some minor modifications though. |
This PR updates the
scripts/bump-version.sh
script to automatically update the dependency onjupyter-ai-magics
to be equal to the current version ofjupyter-ai
in future releases.After this change, when a user upgrades
jupyter-ai
,jupyter-ai-magics
will be upgraded automatically. This will prevent issues like #730 from arising in the future, caused by having different versions ofjupyter-ai
andjupyter-ai-magics
in the same environment.We are already synchronizing the versions of
jupyter-ai
andjupyter-ai-magics
when manually releasing to Conda Forge, so we should be doing the same for PyPI releases.