Skip to content

Commit

Permalink
use an exact version specifier in check-release
Browse files Browse the repository at this point in the history
  • Loading branch information
dlqqq committed Apr 25, 2024
1 parent 599ece0 commit c8137f9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/check-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ jobs:
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
version_spec: minor

# `scripts/bump-version.sh` expects an exact version specifier, not 'patch' or 'minor' or 'major'.
version_spec: "3.0.0"

- name: Runner debug info
if: always()
Expand Down
12 changes: 8 additions & 4 deletions scripts/bump-version.sh
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
#!/bin/bash

# script that bumps version for all projects regardless of whether they were
# changed since last release. needed because `lerna version` only bumps versions for projects
# listed by `lerna changed` by default.
# Script used by Jupyter Releaser that bumps the version of all packages to the
# one provided in `$1`. This script expects an exact version specifier, i.e. it
# does not accept 'patch', 'minor', or 'major' as version specifiers.
#
# see: https://github.com/lerna/lerna/issues/2369
# This script is necessary because a) `lerna version` only bumps versions for
# projects listed by `lerna changed` by default [1], and b) the version in
# `packages/jupyter-ai/pyproject.toml` needs to be bumped as well.
#
# [1]: https://github.com/lerna/lerna/issues/2369

(npx -p lerna@6.4.1 -y lerna version \
--no-git-tag-version \
Expand Down

0 comments on commit c8137f9

Please sign in to comment.